Re: Problem compiling for linux 2.6

[Takashi Iwai <tiwai@suse.de>]

[-- Attachment #1: Type: text/plain, Size: 1206 bytes --]

At Thu, 29 Jan 2004 00:14:16 +0100,
Giuliano Pochini wrote:
> 
> 
> It fails at line #113 of /Makefile :
> 
>         @for d in $(SUBDIRS); do if ! $(MAKE) -C $$d prepare; then exit 1; fi; done
> 
> I have no idea why $(SUBDIRS) is an empty string:
> 
> 
> [Giu@Jay alsa-driver-1.0.2]$ ./cvscompile --with-cards=powermac --with-isapnp=no --with-sequencer=no --with-oss=no --with-kernel=/opt/KernelSrc/l26 --with-debug=full

note that --with-isapnp is ignored on 2.6 kernel.
the isapnp support depends only on the kernel itself.

> [...]
> copying file alsa-kernel/core/memalloc.c
> patching file memalloc.c
> /bin/sh: -c: line 1: syntax error near unexpected token `;'
> /bin/sh: -c: line 1: `for d in   ; do  make -C $d prepare;  done'
> make[1]: *** [prepare] Error 2
> make[1]: Leaving directory `/home/Giu/soft/alsa-driver-1.0.2/acore'
> make: *** [dep] Error 1
> [Giu@Jay alsa-driver-1.0.2]$ uname -a
> Linux Jay 2.6.2-rc1-ben1 #2 SMP Wed Jan 28 22:19:17 CET 2004 ppc unknown
> 
> I'm using ALSA-1.0.2 after it was reuploaded. With linux 2.4 is compile just
> fine as usual. I'm using 2.6 for the first time... maybe I forgot to
> install/update something. :)

does the attached patch work?


Takashi

[-- Attachment #2: Type: text/plain, Size: 1102 bytes --]

Index: alsa-driver/Rules.make
===================================================================
RCS file: /suse/tiwai/cvs/alsa/alsa-driver/Rules.make,v
retrieving revision 1.34
diff -u -r1.34 Rules.make
--- alsa-driver/Rules.make	26 Jan 2004 11:06:03 -0000	1.34
+++ alsa-driver/Rules.make	29 Jan 2004 13:36:40 -0000
@@ -17,8 +17,9 @@
 # apply patches beforehand
 prepare: $(clean-files)
 	@for d in $(patsubst %/,%,$(filter %/, $(obj-y))) \
-	          $(patsubst %/,%,$(filter %/, $(obj-m))); do \
-	 $(MAKE) -C $$d prepare; \
+	          $(patsubst %/,%,$(filter %/, $(obj-m))) DUMMY; do \
+	 echo $$d; \
+	 if [ $$d != DUMMY ]; then $(MAKE) -C $$d prepare; fi; \
 	done
 
 ALL_MOBJS := $(filter-out $(obj-y), $(obj-m))
@@ -29,8 +30,8 @@
 	cp $(ALL_MOBJS:.o=.ko) $(DESTDIR)$(moddir)/$(MODCURDIR)
 endif
 	@for d in $(patsubst %/,%,$(filter %/, $(obj-y))) \
-	          $(patsubst %/,%,$(filter %/, $(obj-m))); do \
-	 $(MAKE) -C $$d modules_install; \
+	          $(patsubst %/,%,$(filter %/, $(obj-m))) DUMMY; do \
+	 if [ $$d != DUMMY ]; then $(MAKE) -C $$d modules_install; fi; \
 	done
 
 else