Re: [PATCH] fix card->power_lock congestion

[Takashi Iwai <tiwai@suse.de>]

At Mon, 20 Oct 2003 11:12:08 +0200 (METDST),
Clemens Ladisch wrote:
> 
> snd_pcm_playback_drain() holds card->power_lock until the substream
> has been drained completely. This prevents any other stream on that
> card from preparing during this time (which is very annoying if one is
> playing several small files which fit entirely into one buffer on a
> multi-stream card like emu10k1 or ymfpci).
> 
> The patch below unlocks power_lock around the schedule() call. As a
> consequence, it is possible to suspend a draining stream, but this has
> already been possible before for streams in non-blocking mode.
> 
> Additionally, I think that snd_pcm_do_suspend() should call the
> trigger callback when the stream is in the draining state, as the
> playback needs to be stopped just as in the running state; and
> similarly for snd_pcm_do_resume(). But I'm not really sure that I know
> what I'm doing here. :)

it should be ok, i think, since the playback and the drain states are
handled same for the lowlevel drivers.

i applied the patch to cvs.  please let me know if something wrong
happens...


thanks,

Takashi


-------------------------------------------------------
This SF.net email is sponsored by OSDN developer relations
Here's your chance to show off your extensive product knowledge
We want to know what you know. Tell us and you have a chance to win $100
http://www.zoomerang.com/survey.zgi?HRPT1X3RYQNC5V4MLNSV3E54