Re: hdsp on big-endian

[Takashi Iwai <tiwai@suse.de>]

Hi Paul,

i converted b_swap's to cpu_to_xxx and xxx_to_cpu macros, and during
that, found that the following part may not work correctly on BE.

static inline unsigned long long hdsp_read64 (hdsp_t *hdsp, int reg)
{
	unsigned long long val;
	val = hdsp_read(hdsp, reg);
	val = (val<<32)|hdsp_read(hdsp, reg + 4);

	return le64_to_cpu(val);
}

since hdsp_read returns the already converted 32bit word, the
resultant 64bit word will be flipped again badly.
i think we don't need here any endian conversion here.
could you confirm this?


ciao,

Takashi

_______________________________________________________________

Don't miss the 2002 Sprint PCS Application Developer's Conference
August 25-28 in Las Vegas -- http://devcon.sprintpcs.com/adp/index.cfm