From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH 1/1] Added functionality for
	E-mu	0404USB/0202USB/TrackerPre
Date: Fri, 25 Dec 2009 14:29:17 +0100
Message-ID: <s5hzl57tc5u.wl%tiwai@suse.de>
References: <794724.87445.qm@web56107.mail.re3.yahoo.com>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx1.suse.de (cantor.suse.de [195.135.220.2])
	by alsa0.perex.cz (Postfix) with ESMTP id 02E962443B
	for <alsa-devel@alsa-project.org>; Fri, 25 Dec 2009 14:29:18 +0100 (CET)
In-Reply-To: <794724.87445.qm@web56107.mail.re3.yahoo.com>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Sender: alsa-devel-bounces@alsa-project.org
Errors-To: alsa-devel-bounces@alsa-project.org
To: Zerg Cannibal <cnb_zerg@yahoo.com>
Cc: alsa-devel@alsa-project.org
List-Id: alsa-devel@alsa-project.org

At Mon, 21 Dec 2009 12:39:27 -0800 (PST),
Zerg Cannibal wrote:
> 
> Added functionality:
> 1) Extension Units support (all XU settings now available at alsamixer, kmix, etc):
>  - "AnalogueIn soft limiter" switch;
>  - "Sample rate" selector (values 0,1,2,3,4,5 corresponds to 44.1 48 ... 192 kHz);
>  - "DigitalIn CLK source" selector (internal/external) (**);
>  - "DigitalOut format SPDIF/AC3" switch (**);
> (**)E-mu-0404usb only.
> 
> 2) Automatic device sample rate adjustment depending on substream samplerate for both capture and playback substream. 
>   
> Patch is based on Mac OS-X driver (http://sourceforge.net/projects/zaudiodrivermac/) and successfully tested by Ubuntu community users for 0404usb and 0202usb.
> 
> Signed-off-by: CannibalZerg <cnb_zerg@yahoo.com>

Thanks for the patch.  Through a quick look, it's fine.
But, could you fix the following and repost?

- Fix warnings suggested by scripts/checkpatch.pl.
  Some 80-chars warnings can be ignored if it makes worse, though.

- Please give the right name and address matching with your from
  address.

Also, the sample rate control could be an enum at best.  But, this
needs more another changes, so let's merge this patch first.


thanks,

Takashi