From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: Patches to azx/patch_realtek.c Date: Wed, 15 Dec 2004 23:09:21 +0100 Message-ID: References: Mime-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: Sender: alsa-devel-admin@lists.sourceforge.net Errors-To: alsa-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: Stephen Warren Cc: alsa-devel@lists.sourceforge.net List-Id: alsa-devel@alsa-project.org At Wed, 15 Dec 2004 13:47:26 -0800, Stephen Warren wrote: > > * realtek.4.diff > > spec->front_panel is no longer used, after Takashi's latest changes. So, > remove it from the structure. I'd like to keep this information in case we'll need some hacks for the front panel switching or any boards without front panel in future. > * realtek.5.diff > > Stop functions directly referencing global variables for configuration > tables - put pointers to the tables into the spec data structure. > > This allows alc880_init to point spec at different sets of data > structures if it needs, and also stops code from knowing about > spec->five_stack, and doing different things depending on the board > type. If we do this, let's merge alc260 code, too :) Maybe it's better to use the array of mixer elem lists than having separate spec->base_mixer and spec->side_mixer as the generalization. Anyway, thanks for the patch. It's ok to merge all these patches to a one (the whole changes shouldn't be too big). But please don't forget to provide signed-off-by line. Takashi ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://productguide.itmanagersjournal.com/