From: Takashi Iwai <tiwai@suse.de>
To: "Zhu, Yi" <yi.zhu@intel.com>
Cc: "Martin Josefsson" <gandalf@wlug.westbo.se>, <perex@suse.cz>,
<akpm@osdl.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Add pci_save_state() to ALSA
Date: Fri, 12 Nov 2004 14:26:14 +0100 [thread overview]
Message-ID: <s5hzn1ndwqx.wl@alsa2.suse.de> (raw)
In-Reply-To: <3ACA40606221794F80A5670F0AF15F8403BD5836@pdsmsx403>
At Fri, 12 Nov 2004 21:00:30 +0800,
Zhu, Yi wrote:
>
> Takashi Iwai wrote:
> > pci_save_state() is called internally in
> > drivers/pci/pci-driver.c:pci_device_suspend(), so it's redundant.
> >
> >> My laptop doesn't resume (gets what I assume is an ACPI timeout and
> >> hangs solid) without this small obvious patch.
> >
> > I'm wondering how this can fix your problem...
>
> For example, some devices call pci_save_state before pci_disable_device
> in
> ->suspend, but don't pci_enable_device in ->resume. This works before,
> but
> is broken after the pci_save_state() change. We need to find those
> drivers out
> and change the individual drivers instead of this simple fix.
But pci_save_state() is called again after the driver's suspend
callback is called. So, the final saved state must be anyway same.
> Martin, which sound driver do you use?
Yep that's important to know.
Takashi
next prev parent reply other threads:[~2004-11-12 13:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-12 13:00 [PATCH] Add pci_save_state() to ALSA Zhu, Yi
2004-11-12 13:26 ` Takashi Iwai [this message]
2004-11-12 13:45 ` Arjan van de Ven
2004-11-12 13:58 ` Takashi Iwai
2004-11-12 16:12 ` Martin Josefsson
-- strict thread matches above, loose matches on Subject: below --
2004-11-11 20:39 Martin Josefsson
2004-11-12 9:22 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hzn1ndwqx.wl@alsa2.suse.de \
--to=tiwai@suse.de \
--cc=akpm@osdl.org \
--cc=gandalf@wlug.westbo.se \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@suse.cz \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.