From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: An driver error when I using aplay!
Date: Mon, 07 Jun 2004 17:32:35 +0200
Sender: alsa-devel-admin@lists.sourceforge.net
Message-ID: <s5hzn7f2xkc.wl@alsa2.suse.de>
References: <20040607092522.29704.qmail@web15206.mail.bjs.yahoo.com>
	<20040607111729.A23059@flint.arm.linux.org.uk>
	<Pine.LNX.4.58.0406071239110.3294@pnote.perex-int.cz>
	<s5hk6yj4jvj.wl@alsa2.suse.de>
	<20040607140817.A28526@flint.arm.linux.org.uk>
	<s5hbrjv4hbs.wl@alsa2.suse.de>
	<20040607145113.B28526@flint.arm.linux.org.uk>
	<s5h4qpn4fjk.wl@alsa2.suse.de>
	<20040607160442.D28526@flint.arm.linux.org.uk>
	<s5h1xkr4d04.wl@alsa2.suse.de>
Mime-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen")
Content-Type: text/plain; charset=US-ASCII
Return-path: <alsa-devel-admin@lists.sourceforge.net>
In-Reply-To: <20040607161812.F28526@flint.arm.linux.org.uk>
Errors-To: alsa-devel-admin@lists.sourceforge.net
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@lists.sourceforge.net?subject=unsubscribe>
List-Post: <mailto:alsa-devel@lists.sourceforge.net>
List-Help: <mailto:alsa-devel-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@lists.sourceforge.net?subject=subscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum=alsa-devel>
To: Russell King <rmk+alsa@arm.linux.org.uk>
Cc: Jaroslav Kysela <perex@suse.cz>, Roc Wu <cooloney@yahoo.com.cn>, Clemens Ladisch <clemens@ladisch.de>, Alsa-devel@lists.sourceforge.net
List-Id: alsa-devel@alsa-project.org

At Mon, 7 Jun 2004 16:18:12 +0100,
Russell King wrote:
> 
> > No, the problematic line is:
> > 
> > 	WARN_ON(chan->tx_substream != substream);
> > 
> > It can't pass because chan->tx_substream is always NULL (as you wrote)
> > unless hw_params is called.  The check is wrong.
> 
> Ah, well, in my current version of this, I've completely removed that
> check.  Whether there are any other changes, I've no idea.

I also won't debug this any more unless the code is opened
publicly...

>   However,
> my current version doesn't work at all at the moment because its in
> the middle of having experimental DMA support added, rather than
> being sucky PIO-only.

Where we're here:  I'd really like to fix the DMA problem of ALSA on
ARM.  As I sent you before, the patch is already there but I have no
idea whether it's really right or not.  Could you please comment
whether the assumptions below are correct?

- the page struct can be retrieved from dma_addr_t of
  dma_alloc_coherent() like

	virt_to_page(bus_to_virt(addr))

- adding pgprot_noncached() in fop->mmap callback assures that the
  mmaped page is accessed without cache side effects.


thanks,

Takashi


-------------------------------------------------------
This SF.Net email is sponsored by: GNOME Foundation
Hackers Unite!  GUADEC: The world's #1 Open Source Desktop Event.
GNOME Users and Developers European Conference, 28-30th June in Norway
http://2004/guadec.org