From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH] Audigy LS support. Date: Fri, 28 May 2004 12:07:41 +0200 Sender: alsa-devel-admin@lists.sourceforge.net Message-ID: References: <40B63EBD.6060407@superbug.demon.co.uk> Mime-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen") Content-Type: text/plain; charset=US-ASCII Return-path: Received: from Cantor.suse.de (cantor.suse.de [195.135.220.2]) by alsa.alsa-project.org (8.9.3/8.9.3/SuSE Linux 8.9.3-0.1) with ESMTP id MAA12417 for ; Fri, 28 May 2004 12:07:48 +0200 In-Reply-To: <40B63EBD.6060407@superbug.demon.co.uk> Errors-To: alsa-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: James Courtier-Dutton Cc: ALSA development List-Id: alsa-devel@alsa-project.org At Thu, 27 May 2004 20:17:17 +0100, James Courtier-Dutton wrote: > > Here is my first go at Audigy LS support. > It can play sound to the front speakers. great! > /* hardware definition */ > static snd_pcm_hardware_t snd_audigyls_playback_hw = { > .info = (SNDRV_PCM_INFO_MMAP | > SNDRV_PCM_INFO_INTERLEAVED | > SNDRV_PCM_INFO_BLOCK_TRANSFER | > SNDRV_PCM_INFO_MMAP_VALID), > .formats = SNDRV_PCM_FMTBIT_S16_LE, > .rates = SNDRV_PCM_RATE_48000, > .rate_min = 48000, > .rate_max = 48000, > .channels_min = 2, > .channels_max = 2, > .buffer_bytes_max = (32*1024), > .period_bytes_min = 64, > .period_bytes_max = (16*1024), > .periods_min = 2, > .periods_max = 16, ^^ are you sure this is ok? in the case of emu10k1, it generates irq twice per buffer (HALF and BUFFER). then periods_max must be 2. anyway, the driver code is quite similar with emu10k1x.c. i checked the diff between them and the amount of difference is really small. how about merging them? then we can understand / maintain the codes better. Takashi ------------------------------------------------------- This SF.Net email is sponsored by: Oracle 10g Get certified on the hottest thing ever to hit the market... Oracle 10g. Take an Oracle 10g class now, and we'll give you the exam FREE. http://ads.osdn.com/?ad_id=3149&alloc_id=8166&op=click