From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: Re: [PATCH] USB MIDI driver Date: Thu, 04 Jul 2002 11:47:31 +0200 Sender: alsa-devel-admin@lists.sourceforge.net Message-ID: References: <3D208C5C.36649172@ladisch.de> <3D22F37D.14EE3DAB@ladisch.de> <3D230D63.8ED93F9D@ladisch.de> Mime-Version: 1.0 (generated by SEMI 1.14.3 - "Ushinoya") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <3D230D63.8ED93F9D@ladisch.de> Errors-To: alsa-devel-admin@lists.sourceforge.net List-Help: List-Post: List-Subscribe: , List-Unsubscribe: , List-Archive: To: alsa-devel@lists.sourceforge.net List-Id: alsa-devel@alsa-project.org At Wed, 03 Jul 2002 16:42:43 +0200, Clemens Ladisch wrote: > > Takashi Iwai wrote: > > Clemens Ladisch wrote: > > > and virmidi with SNDRV_VIRMIDI_SEQ_ATTACH doesn't support input anyway, > > > > hmm, this mode wasn't tested, too. usb-midi is the first case. > > doesn't rawmidi read work at all? > > The driver calls snd_seq_kernel_client_dispatch() to get rid of an event. > To receive a sequencer event, virmidi would need its own sequencer client > (or port), like it does with SNDRV_VIRMIDI_SEQ_DISPATCH, but then we would > have two sequencer clients. oh, yes, you're right. > Alternatively, usb-midi could call snd_virmidi_receive() directly, but that > smells somewhat like a hack. (I've noticed that snd_virmidi_receive() isn't > declared static, although it isn't exported either. :-) i think it's the easiest and cleanest way. actually this was declared as external intentionally for such a purpose, but just forgotten to be exported :) i changed virmidi codes for easier use, and added snd_virmidi_receive() to usbmidi.c. could you check the updated driver? ciao, Takashi ------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek Caffeinated soap. No kidding. http://thinkgeek.com/sf