From: Christian Dietrich <christian.dietrich@tuhh.de>
To: Mike Rapoport <rppt@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Mike Rapoport <rppt@kernel.org>,
Mike Rapoport <rppt@linux.ibm.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] mm/pgtable: define pte_index so that preprocessor could recognize it
Date: Tue, 11 Jan 2022 16:20:34 +0100 [thread overview]
Message-ID: <s7bzgo2cn99.fsf@dokucode.de> (raw)
In-Reply-To: <20220111145457.20748-1-rppt@kernel.org>
Hello Mike!
Mike Rapoport <rppt@kernel.org> [11. Januar 2022]:
> diff --git a/include/linux/pgtable.h b/include/linux/pgtable.h
> index e24d2c992b11..d468efcf48f4 100644
> --- a/include/linux/pgtable.h
> +++ b/include/linux/pgtable.h
> @@ -62,6 +62,7 @@ static inline unsigned long pte_index(unsigned long address)
> {
> return (address >> PAGE_SHIFT) & (PTRS_PER_PTE - 1);
> }
> +#define pte_index pte_index
Wouldn't it make sense to remove the dead CPP blocks (#ifdef pte_index)
from mm/memory.c? Or is there a case were pte_index is not defined for
an architecture?
chris
--
Prof. Dr.-Ing. Christian Dietrich
Operating System Group (E-EXK4)
Technische Universität Hamburg
Am Schwarzenberg-Campus 3 (E), 4.092
21073 Hamburg
eMail: christian.dietrich@tuhh.de
Tel: +49 40 42878 2188
WWW: https://osg.tuhh.de/
next prev parent reply other threads:[~2022-01-11 15:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-11 14:54 [PATCH] mm/pgtable: define pte_index so that preprocessor could recognize it Mike Rapoport
2022-01-11 15:20 ` Christian Dietrich [this message]
2022-01-11 17:10 ` Mike Rapoport
2022-01-11 18:44 ` Khalid Aziz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s7bzgo2cn99.fsf@dokucode.de \
--to=christian.dietrich@tuhh.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rppt@kernel.org \
--cc=rppt@linux.ibm.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.