From: James Calligeros <jcalligeros99@gmail.com>
To: "Martin Povišer" <povik+lin@cutebit.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Jaroslav Kysela" <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>,
"Joshua Peisach" <jpeisach@ubuntu.com>
Cc: asahi@lists.linux.dev, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/7] ASoC: apple: mca: Support FEs being clock consumers
Date: Sun, 05 Jul 2026 12:05:33 +1000 [thread overview]
Message-ID: <sCELYiNQSvCxqjQFP0uhkQ@gmail.com> (raw)
In-Reply-To: <DJLKAJ8IU0Z5.EU158RDQ31H0@ubuntu.com>
Hi Josh,
On Monday, 29 June 2026 11:19:27 pm Australian Eastern Standard Time Joshua
Peisach wrote:
> On Sun Jun 28, 2026 at 7:42 AM EDT, James Calligeros wrote:
> > + writel_relaxed(port + 6 + 1,
> > + cl->base + REG_SYNCGEN_MCLK_SEL);
>
> Where does the "6 + 1" come from, and should it have its own #define?
This actually only ever gets set to 0b111 (port = 0), and trying to set
it to anything else breaks the machines which consume VISENSE data from
the connected codecs. I will just replace this with a static value for
v3, which seems to work on all the machines we currently support downstream.
> -Josh
James
next prev parent reply other threads:[~2026-07-05 2:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-28 11:41 [PATCH v2 0/7] ASoC: apple: mca: support simultaneous I2S capture on the frontend James Calligeros
2026-06-28 11:41 ` [PATCH v2 1/7] ASoC: apple: mca: increase SERDES reset delay James Calligeros
2026-06-28 11:42 ` [PATCH v2 2/7] ASoC: apple: mca: Separate data & clock port setup James Calligeros
2026-06-28 11:42 ` [PATCH v2 3/7] ASoC: apple: mca: Factor out mca_be_get_fe James Calligeros
2026-06-28 11:42 ` [PATCH v2 4/7] ASoC: apple: mca: Support FEs being clock consumers James Calligeros
2026-06-29 13:19 ` Joshua Peisach
2026-07-05 2:05 ` James Calligeros [this message]
2026-06-28 11:42 ` [PATCH v2 5/7] ASoC: apple: mca: Support capture on multiples BEs James Calligeros
2026-06-28 11:42 ` [PATCH v2 6/7] ASoC: apple: mca: Do not mark clocks in use for non-providers James Calligeros
2026-06-28 11:42 ` [PATCH v2 7/7] ASoC: apple: mca: Add delay after configuring clock James Calligeros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sCELYiNQSvCxqjQFP0uhkQ@gmail.com \
--to=jcalligeros99@gmail.com \
--cc=asahi@lists.linux.dev \
--cc=broonie@kernel.org \
--cc=jpeisach@ubuntu.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=povik+lin@cutebit.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.