All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Gaylard <ag@ffroot.co.za>
To: Julian Braha <julianbraha@gmail.com>
Cc: linux@armlinux.org.uk,  dvorkin@tibbo.com,  wellslutw@gmail.com,
	linusw@kernel.org,  arnd@arndb.de,  afd@ti.com,
	 aaro.koskinen@iki.fi, linux-arm-kernel@lists.infradead.org,
	 linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH] pinctrl: fix PINCTRL_SPPCTL=m
Date: Wed, 16 Sep 2026 12:31:00 +0200	[thread overview]
Message-ID: <sa6fqz9ij2z.fsf@dev-ag> (raw)
In-Reply-To: <20260904121825.43320-1-julianbraha@gmail.com> (Julian Braha's message of "Fri, 4 Sep 2026 13:18:25 +0100")

Julian Braha <julianbraha@gmail.com> writes:

> The PINCTRL_SPPCTL option is defined as a tristate in Kconfig, and the
> help text suggests that the user can build it as a module by setting to
> 'm'.
[...]
> Note that I have only compile-tested this change, since I do not have the
> hardware to runtime-test it. Please advise if it would be better to change
> PINCTRL_SPPCTL to 'bool' and remove the help text suggesting that it can
> be set to 'm'.

Hi Julian,

I've tested this on real hardware, and it fails to boot.  I don't think
it makes sense for this to be a module, since most of the devices in
this SoC are pin-mappable and need muxing to be configured before they
can be probed.

Let's rather fix this by making it a bool.  I'll send a patch shortly.

-- 
Andrew

  reply	other threads:[~2026-09-16 10:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-04 12:18 [PATCH] pinctrl: fix PINCTRL_SPPCTL=m Julian Braha
2026-09-16 10:31 ` Andrew Gaylard [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-09-16 10:49 Andrew Gaylard
2026-09-20 22:23 ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sa6fqz9ij2z.fsf@dev-ag \
    --to=ag@ffroot.co.za \
    --cc=aaro.koskinen@iki.fi \
    --cc=afd@ti.com \
    --cc=arnd@arndb.de \
    --cc=dvorkin@tibbo.com \
    --cc=julianbraha@gmail.com \
    --cc=linusw@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=wellslutw@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.