Re: [PATCH v7 7/8] KVM: selftests: Only warn for idle-page checks on powerpc pseries LPAR

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] selftests: typo 'explicitely' in comment
--

commit 87fed9598d0ceb8998ad38373e71f38a0d2446ab
Author: Ritesh Harjani (IBM) <ritesh.list@gmail.com>

KVM: selftests: Only warn for idle-page checks on powerpc pseries LPAR

This commit updates the access tracking selftest for KVM to only warn on
idle-page checks when running nested on powerpc pseries LPAR. It uses a new
kvm_is_ppc_pseries_lpar() check to detect this condition because nested KVM
on powerpc does not explicitly flush the TLB for access bit updates.

[ ... ]

> diff --git a/tools/testing/selftests/kvm/access_tracking_perf_test.c b/tools/testing/selftests/kvm/access_tracking_perf_test.c
> index 4415c94b28660..eb6939065e793 100644
> --- a/tools/testing/selftests/kvm/access_tracking_perf_test.c
> +++ b/tools/testing/selftests/kvm/access_tracking_perf_test.c
> @@ -471,6 +471,16 @@ static int access_tracking_unreliable(void)
>  		return 1;
>  	}
>  #endif
> +	/*
> +	 * PowerPC: Nested KVM (pSeries LPAR) can hide accessed/idle, since KVM
> +	 * doesn't explicitely flush the TLB for access bit update. L0 keeps

[Severity: Low]
This isn't a bug, but there appears to be a typo here. Should explicitely be
spelled explicitly?

> +	 * translations cached so the guest won't see the idle bit cleared.
> +	 */
> +	if (kvm_is_ppc_pseries_lpar()) {
> +		puts("Skipping idle page count sanity check, because the test is run nested");
> +		return 1;
> +	}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1791280439.git.ritesh.list@gmail.com?part=7