Re: [PATCH net-next v2 1/2] dt-bindings: net: realtek,rtl82xx: document RTL8224 packages

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: net: generic compatible in example fails schema validation
--

commit 6e9280e0153fb3196c44f745f9db18bcf7971400
Author: Oskari Lemmela <oskari@lemmela.net>

dt-bindings: net: realtek,rtl82xx: document RTL8224 packages

This commit updates the realtek,rtl82xx bindings to document RTL8224 PHY
packages and adds an example demonstrating multiple child PHY nodes within an
ethernet-phy-package.

> diff --git a/Documentation/devicetree/bindings/net/realtek,rtl82xx.yaml b/Documentation/devicetree/bindings/net/realtek,rtl82xx.yaml
> index 07b39ef1fc624..ca52c3ae19f7a 100644
> --- a/Documentation/devicetree/bindings/net/realtek,rtl82xx.yaml
> +++ b/Documentation/devicetree/bindings/net/realtek,rtl82xx.yaml
[ ... ]
> @@ -90,9 +100,45 @@ examples:
>          #address-cells = <1>;
>          #size-cells = <0>;
>  
[ ... ]
> +        ethernet-phy-package@1 {
> +            reg = <1>;
> +            #address-cells = <1>;
> +            #size-cells = <0>;
> +
> +            ethernet-phy@1 {
> +                compatible = "ethernet-phy-ieee802.3-c45";

[Severity: Low]
Does this generic compatible string cause a schema validation warning during
make dt_binding_check? 

Because this generic string is not listed in the schema's compatible enum,
the implicit select logic generated for this schema fails to match the
example node. The dt-schema tool strictly requires examples to match their
enclosing schema, so this mismatch will trigger a validation error.

> +                reg = <1>;
> +                enet-phy-pair-order = <0>;
> +            };
> +
> +            ethernet-phy@2 {
> +                compatible = "ethernet-phy-ieee802.3-c45";
> +                reg = <2>;
> +                enet-phy-pair-order = <0>;
> +            };
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261005201540.913977-1-oskari@lemmela.net?part=1