Re: [PATCH net-next v3] dt-bindings: net: Convert HiSilicon hns-dsaf to DT schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: net: incorrect additionalProperties in port node rejects inherited properties
--

commit 1a8f2a688cef19a71010006753fe6e776c15501b
Author: Rob Herring (Arm) <robh@kernel.org>

dt-bindings: net: Convert HiSilicon hns-dsaf to DT schema

Convert the HiSilicon hns-dsaf binding to DT schema format. Drop the unused
phy-handle at the top level, add the undocumented media-type property, and
drop support for 4 reg regions as they have long been deprecated.

> diff --git a/Documentation/devicetree/bindings/net/hisilicon,hns-dsaf-v1.yaml b/Documentation/devicetree/bindings/net/hisilicon,hns-dsaf-v1.yaml
> new file mode 100644
> index 0000000000000..4629acbba8104
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/hisilicon,hns-dsaf-v1.yaml
> @@ -0,0 +1,170 @@
> [ ... ]
> +patternProperties:
> +  "^port@[0-5]$":
> +    description: DSA Fabric port node
> +    $ref: ethernet-switch-port.yaml#
> +    additionalProperties: false

[Severity: Medium]
Will this incorrectly reject standard ethernet port properties inherited from
ethernet-switch-port.yaml?

In JSON Schema, additionalProperties does not consider properties defined
within a $ref. Thus, any property defined in the referenced schema but not
explicitly listed in the local properties block will be incorrectly rejected.

Should this use unevaluatedProperties: false instead when inheriting from
another schema?

> +
> +    properties:
> +      reg:
> +        maximum: 5
> [ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261005202808.1982164-2-robh@kernel.org?part=1