Re: [PATCH 1/1] drm/xe: fixing endless PF range response

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] drm/xe: build failure due to hallucinated vma_info field
--

commit 634f5ddbb1931a170d6586933045107086b28191
Author: Fei Yang <fei.yang@intel.com>
Subject: drm/xe: fixing endless PF range response

This commit modifies the page fault queue worker to immediately update the
start and end addresses of a page fault. It also adds assignments to a new
vma_info structure inside the page fault consumer.

> diff --git a/drivers/gpu/drm/xe/xe_pagefault.h b/drivers/gpu/drm/xe/xe_pagefault.h
> index 799c984dee84f..5ce2f6ed10c56 100644
> --- a/drivers/gpu/drm/xe/xe_pagefault.h
> +++ b/drivers/gpu/drm/xe/xe_pagefault.h
> @@ -98,6 +98,7 @@ xe_pagefault_set_end_addr(struct xe_pagefault *pf, u64 end_addr)
>  {
>  	pf->consumer.end_addr &= ~XE_PAGEFAULT_END_ADDR_MASK;
>  	pf->consumer.end_addr |= end_addr;
> +	pf->consumer.vma_info.end_addr = end_addr;

[Severity: Low]
Does the consumer structure actually have a vma_info member?

Looking at the definition in drivers/gpu/drm/xe/xe_pagefault_types.h:

struct xe_pagefault {
...
	struct {
		u64 page_addr;
		union {
			struct {
				u8 alloc_state;
...
				u32 id;
			};
			u64 end_addr;
		};
		struct xe_pagefault *next;
	} consumer;
...
};

It appears consumer lacks a vma_info field. Will this code compile, or will
it result in a build error complaining about no member named vma_info?

[ ... ]

> @@ -137,6 +138,7 @@ xe_pagefault_set_start_addr(struct xe_pagefault *pf, u64 start_addr)
>  {
>  	pf->consumer.page_addr &= XE_PAGEFAULT_ERROR_MASK;
>  	pf->consumer.page_addr |= (start_addr & ~XE_PAGEFAULT_ERROR_MASK);
> +	pf->consumer.vma_info.start_addr = start_addr;

[Severity: Low]
Similarly, since vma_info doesn't exist in consumer, will this assignment also
cause a compiler error?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261006213449.4027749-1-fei.yang@intel.com?part=1