From: sashiko-bot@kernel.org
To: "Bob Hui" <bg9oxa@163.com>
Cc: robh@kernel.org, devicetree@vger.kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v8 2/2] arm64: dts: rockchip: Add ALIENTEK QuarkPi-CA2
Date: Wed, 07 Oct 2026 05:29:55 +0000 [thread overview]
Message-ID: <sashiko-outbox-162642@kernel.org> (raw)
In-Reply-To: <20261007-quarkpi-ca2-v8-2-b83192bed07b@163.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dts: commit message claims two LEDs but only one is defined
--
commit f459a1ed57a7152764a79524707ba54a9a7ff857
Author: Bob Hui <bg9oxa@163.com>
arm64: dts: rockchip: Add ALIENTEK QuarkPi-CA2
This commit adds a device tree for the ALIENTEK QuarkPi-CA2, an RK3588S
based card computer. It describes supported peripherals including Ethernet,
HDMI, USB, audio components, and basic I/O like keys and LEDs.
Closes: https://lore.kernel.org/all/sashiko-outbox-162297@kernel.org/
> - 3.5 mm headset jack (headphones + microphone) with the ES8388
> codec, the headphone amplifier and jack detection
> - three function keys (volume down, volume up and PWR_ON from the
> PMIC) and the headset hook button
> - IR receiver, 4-pin PWM fan connector and two LEDs
> - 3-wire debug UART (UART2)
[Severity: Low]
This isn't a bug, but the commit message claims two LEDs are supported,
while the device tree implementation only defines a single work_led in the
gpio-leds node.
Is the second LED missing from the implementation, or should the commit
message be updated to reflect the single LED?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261007-quarkpi-ca2-v8-0-b83192bed07b@163.com?part=2
next prev parent reply other threads:[~2026-10-07 5:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-07 5:18 [PATCH v8 0/2] arm64: dts: rockchip: Add ALIENTEK QuarkPi-CA2 Bob Hui
2026-10-07 5:18 ` Bob Hui
2026-10-07 5:18 ` [PATCH v8 1/2] dt-bindings: arm: " Bob Hui
2026-10-07 5:18 ` Bob Hui
2026-10-07 9:52 ` Conor Dooley
2026-10-07 9:52 ` Conor Dooley
2026-10-07 5:18 ` [PATCH v8 2/2] arm64: dts: " Bob Hui
2026-10-07 5:18 ` Bob Hui
2026-10-07 5:29 ` sashiko-bot [this message]
2026-10-07 6:24 ` Bob Hui
2026-10-07 6:24 ` Bob Hui
2026-10-11 3:31 ` Shawn Lin
2026-10-11 3:31 ` Shawn Lin
2026-10-12 20:00 ` Bob Hui
2026-10-12 20:00 ` Bob Hui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-162642@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=bg9oxa@163.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.