From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 27EAD40680F; Wed, 7 Oct 2026 06:40:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791355260; cv=none; b=fIqy6DFs4WtzeQkwxvYD/G6Sa0bIVTg8HJgaJ5/VvXu7D1a5dL5B5N1TRgddprGbStQ8ODOun6TY1PglitFj04t+1k9q/Lng725gT3BZwSZOHA1Hi5l31unA2Mmy7rxtJBiDQY5GSqVjHeKlJx+E84gQ4189tl1B4Wy473ZRiVY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791355260; c=relaxed/simple; bh=o0/Fgp1InkZxt733SjzVx4zmoGCsZLtiV7ANND6osNU=; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type: Date; b=HbtI9nziz8AzMOSHkSlRlBerPolLDbUXROKiHks3vGuOdYsJhnv25l7MYi8TJouvOeKQ5HBxYwgYKXCdJ6XCsiGwMVvmyN3/vhyaPgAg1Exvb+9GJUajcUXwOjVWW2xeRhCyl8fkOKWR2Hm8jL6nDRbY8NDaL1KpJP86otr4A94= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FhYWwhbv; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FhYWwhbv" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7989D1F0089B; Wed, 7 Oct 2026 06:40:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791355259; bh=Pf3NWyRPQ0L09auWXUFmkUX75lTJ6eVPIYX7Gh2FhzI=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=FhYWwhbv/MivxQqipS5QvCY19Wu90M2LelaZWzZRyhcOk2GpxRX8vob1LAt/WFfbj n/mgPxO5js60SdTkD6Mn/2PXL7iY9AaHbgU2m+XABmRsrLWn3oqyUScqkqZBUeZolo AQQfJdKnNXY9d4WSwuAQis111lnGqQJEb1OvRdk1zwQ8/C6odGb5q4rM+9FHzkPigL 6Ewus/p4jUFOtOuV19qTHqcFGO0e2ijcM3WgMQyk+0dVqagfeX7pSEeTE9tlfw+5lT bLccITWPlbHNiaW62UUt7pKW+Z4hyWtdhwaQN5+vZaTKHWFdy7+vinNAFVQJdxaTie 28vjkJdOapn/Q== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v3 3/5] arm64: dts: qcom: glymur: Add UFS nodes Reply-To: sashiko-reviews@lists.linux.dev To: "Pradeep P V K" Cc: devicetree@vger.kernel.org, robh@kernel.org, olteanv@gmail.com, vkoul@kernel.org, linux-phy@lists.infradead.org, conor+dt@kernel.org, neil.armstrong@linaro.org, linux-scsi@vger.kernel.org In-Reply-To: <20261007-glymur_ufs_qcb_enablement-v3-3-84cf4f861415@oss.qualcomm.com> References: <20261007-glymur_ufs_qcb_enablement-v3-0-84cf4f861415@oss.qualcomm.com> <20261007-glymur_ufs_qcb_enablement-v3-3-84cf4f861415@oss.qualcomm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Wed, 07 Oct 2026 06:40:58 +0000 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Medium] dts: missing required power-domains property in ufs_mem_phy -- commit cc6e215ec76c80b1408b03a4a6419de1ac3953d3 Author: Pradeep P V K arm64: dts: qcom: glymur: Add UFS nodes Add UFS PHY and UFS host controller nodes for Glymur SoC. > diff --git a/arch/arm64/boot/dts/qcom/glymur.dtsi b/arch/arm64/boot/dts/q= com/glymur.dtsi > index 65a398c0a9920..49ef89b41aada 100644 > --- a/arch/arm64/boot/dts/qcom/glymur.dtsi > +++ b/arch/arm64/boot/dts/qcom/glymur.dtsi [ ... ] > @@ -4102,6 +4102,125 @@ rng: rng@10c3000 { > reg =3D <0x0 0x010c3000 0x0 0x1000>; > }; > =20 > + ufs_mem_phy: phy@1d80000 { > + compatible =3D "qcom,glymur-qmp-ufs-phy"; > + reg =3D <0x0 0x01d80000 0x0 0x2000>; > + > + clocks =3D <&rpmhcc RPMH_CXO_CLK>, > + <&gcc GCC_UFS_PHY_PHY_AUX_CLK>, > + /* UFS and PCIE4 share the same clkref */ > + <&tcsr TCSR_PCIE_4_CLKREF_EN>; > + > + clock-names =3D "ref", > + "ref_aux", > + "qref"; > + > + resets =3D <&ufs_mem_hc 0>; > + reset-names =3D "ufsphy"; > + > + #clock-cells =3D <1>; > + #phy-cells =3D <0>; > + > + status =3D "disabled"; > + }; [Severity: Medium] Is the ufs_mem_phy node missing a power-domains property? This node appears to violate the qcom,sc8280xp-qmp-ufs-phy.yaml DT schema by omitting this required property. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261007-glymur_ufs= _qcb_enablement-v3-0-84cf4f861415@oss.qualcomm.com?part=3D3 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 63B79CA5FFF for ; Wed, 7 Oct 2026 06:41:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date:References: In-Reply-To:Cc:To:Subject:From:Message-ID:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/CsXzoqTMnROdhZZHBLSJbpuSX4B2q1Ff4XlS+WabSA=; b=bpYXrnCqobt2lw U6loPW91qIwcJL/T3lJs1W0WV893yPeexjeQD0aVYnOz1BDbXzc5AoxEL8mHI5bGJpvxTqSEFazXW rM+9mALRW/k3YRGsmgBuRUzT3UhzqRfiZW12LEMdeS/bQcXvq3U5ASteDpOxFYJuuZTyeVTqDuDrO HRYvpFgMKsSGVhvl+2FTa5zJw/xtnuwc3zVxU0I1DuFda+yq48+/GxM4IN8OayS90PaRP+yQBebXk 9g2m+9zZqqxybzPjA+FqaYkHne3iG7rS0Aczs3rtndMBoKDRTuGAac5vVLR39iz77w8/QR2l7/uc3 R7r99BfVJ421WGuVfjxQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xELKo-00000001n8y-008S; Wed, 07 Oct 2026 06:41:02 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xELKn-00000001n8q-2Qrq for linux-phy@lists.infradead.org; Wed, 07 Oct 2026 06:41:01 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 13E9841087; Wed, 7 Oct 2026 06:40:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7989D1F0089B; Wed, 7 Oct 2026 06:40:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791355259; bh=Pf3NWyRPQ0L09auWXUFmkUX75lTJ6eVPIYX7Gh2FhzI=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=FhYWwhbv/MivxQqipS5QvCY19Wu90M2LelaZWzZRyhcOk2GpxRX8vob1LAt/WFfbj n/mgPxO5js60SdTkD6Mn/2PXL7iY9AaHbgU2m+XABmRsrLWn3oqyUScqkqZBUeZolo AQQfJdKnNXY9d4WSwuAQis111lnGqQJEb1OvRdk1zwQ8/C6odGb5q4rM+9FHzkPigL 6Ewus/p4jUFOtOuV19qTHqcFGO0e2ijcM3WgMQyk+0dVqagfeX7pSEeTE9tlfw+5lT bLccITWPlbHNiaW62UUt7pKW+Z4hyWtdhwaQN5+vZaTKHWFdy7+vinNAFVQJdxaTie 28vjkJdOapn/Q== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v3 3/5] arm64: dts: qcom: glymur: Add UFS nodes To: "Pradeep P V K" Cc: devicetree@vger.kernel.org, robh@kernel.org, olteanv@gmail.com, vkoul@kernel.org, linux-phy@lists.infradead.org, conor+dt@kernel.org, neil.armstrong@linaro.org, linux-scsi@vger.kernel.org In-Reply-To: <20261007-glymur_ufs_qcb_enablement-v3-3-84cf4f861415@oss.qualcomm.com> References: <20261007-glymur_ufs_qcb_enablement-v3-0-84cf4f861415@oss.qualcomm.com> <20261007-glymur_ufs_qcb_enablement-v3-3-84cf4f861415@oss.qualcomm.com> Date: Wed, 07 Oct 2026 06:40:58 +0000 X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW01lZGl1bV0gZHRzOiBtaXNzaW5n IHJlcXVpcmVkIHBvd2VyLWRvbWFpbnMgcHJvcGVydHkgaW4gdWZzX21lbV9waHkKLS0KCmNvbW1p dCBjYzZlMjE1ZWM3NmM4MGIxNDA4YjAzYTRhNjQxOWRlMWFjMzk1M2QzCkF1dGhvcjogUHJhZGVl cCBQIFYgSyA8cHJhZGVlcC5wcmFnYWxsYXBhdGlAb3NzLnF1YWxjb21tLmNvbT4KCmFybTY0OiBk dHM6IHFjb206IGdseW11cjogQWRkIFVGUyBub2RlcwoKQWRkIFVGUyBQSFkgYW5kIFVGUyBob3N0 IGNvbnRyb2xsZXIgbm9kZXMgZm9yIEdseW11ciBTb0MuCgo+IGRpZmYgLS1naXQgYS9hcmNoL2Fy bTY0L2Jvb3QvZHRzL3Fjb20vZ2x5bXVyLmR0c2kgYi9hcmNoL2FybTY0L2Jvb3QvZHRzL3Fjb20v Z2x5bXVyLmR0c2kKPiBpbmRleCA2NWEzOThjMGE5OTIwLi40OWVmODliNDFhYWRhIDEwMDY0NAo+ IC0tLSBhL2FyY2gvYXJtNjQvYm9vdC9kdHMvcWNvbS9nbHltdXIuZHRzaQo+ICsrKyBiL2FyY2gv YXJtNjQvYm9vdC9kdHMvcWNvbS9nbHltdXIuZHRzaQpbIC4uLiBdCj4gQEAgLTQxMDIsNiArNDEw MiwxMjUgQEAgcm5nOiBybmdAMTBjMzAwMCB7Cj4gIAkJCXJlZyA9IDwweDAgMHgwMTBjMzAwMCAw eDAgMHgxMDAwPjsKPiAgCQl9Owo+ICAKPiArCQl1ZnNfbWVtX3BoeTogcGh5QDFkODAwMDAgewo+ ICsJCQljb21wYXRpYmxlID0gInFjb20sZ2x5bXVyLXFtcC11ZnMtcGh5IjsKPiArCQkJcmVnID0g PDB4MCAweDAxZDgwMDAwIDB4MCAweDIwMDA+Owo+ICsKPiArCQkJY2xvY2tzID0gPCZycG1oY2Mg UlBNSF9DWE9fQ0xLPiwKPiArCQkJCSA8JmdjYyBHQ0NfVUZTX1BIWV9QSFlfQVVYX0NMSz4sCj4g KwkJCQkgLyogVUZTIGFuZCBQQ0lFNCBzaGFyZSB0aGUgc2FtZSBjbGtyZWYgKi8KPiArCQkJCSA8 JnRjc3IgVENTUl9QQ0lFXzRfQ0xLUkVGX0VOPjsKPiArCj4gKwkJCWNsb2NrLW5hbWVzID0gInJl ZiIsCj4gKwkJCQkgICAgICAicmVmX2F1eCIsCj4gKwkJCQkgICAgICAicXJlZiI7Cj4gKwo+ICsJ CQlyZXNldHMgPSA8JnVmc19tZW1faGMgMD47Cj4gKwkJCXJlc2V0LW5hbWVzID0gInVmc3BoeSI7 Cj4gKwo+ICsJCQkjY2xvY2stY2VsbHMgPSA8MT47Cj4gKwkJCSNwaHktY2VsbHMgPSA8MD47Cj4g Kwo+ICsJCQlzdGF0dXMgPSAiZGlzYWJsZWQiOwo+ICsJCX07CgpbU2V2ZXJpdHk6IE1lZGl1bV0K SXMgdGhlIHVmc19tZW1fcGh5IG5vZGUgbWlzc2luZyBhIHBvd2VyLWRvbWFpbnMgcHJvcGVydHk/ CgpUaGlzIG5vZGUgYXBwZWFycyB0byB2aW9sYXRlIHRoZSBxY29tLHNjODI4MHhwLXFtcC11ZnMt cGh5LnlhbWwgRFQgc2NoZW1hIGJ5Cm9taXR0aW5nIHRoaXMgcmVxdWlyZWQgcHJvcGVydHkuCgot LSAKU2FzaGlrbyBBSSByZXZpZXcgwrcgaHR0cHM6Ly9zYXNoaWtvLmRldi8jL3BhdGNoc2V0LzIw MjYxMDA3LWdseW11cl91ZnNfcWNiX2VuYWJsZW1lbnQtdjMtMC04NGNmNGY4NjE0MTVAb3NzLnF1 YWxjb21tLmNvbT9wYXJ0PTMKCi0tIApsaW51eC1waHkgbWFpbGluZyBsaXN0CmxpbnV4LXBoeUBs aXN0cy5pbmZyYWRlYWQub3JnCmh0dHBzOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2xpbnV4LXBoeQo=