Re: [PATCH v23 03/14] KVM: arm64: Include kvm_emulate.h in kvm/arm_psci.h

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Commit message incorrectly claims fix for vcpu_has_feature instead of vcpu_set_reg
--

commit 2bee02b3a3b5f85d378a4e48c38b6750bc566ae1
Author: Suzuki K Poulose <suzuki.poulose@arm.com>

KVM: arm64: Include kvm_emulate.h in kvm/arm_psci.h

This commit adds an include for asm/kvm_emulate.h in include/kvm/arm_psci.h
to fix an implicit function declaration build error.

>     ./include/kvm/arm_psci.h: In function ‘kvm_psci_version’:
>     ./include/kvm/arm_psci.h:29:13: error: implicit declaration of function
>        ‘vcpu_has_feature’; did you mean ‘cpu_have_feature’? [-Werror=implicit-function-declaration]
>        29 |         if (vcpu_has_feature(vcpu, KVM_ARM_VCPU_PSCI_0_2)) {
>                      |             ^~~~~~~~~~~~~~~~
>                                    |             cpu_have_feature

[Severity: Low]
Is this compiler error accurately reflecting the issue fixed by the patch?

Looking at the headers, vcpu_has_feature is actually defined in
arch/arm64/include/asm/kvm_host.h, which is already included via
linux/kvm_host.h at the top of the file.

The added asm/kvm_emulate.h header does not define vcpu_has_feature. Instead,
it provides the inline definitions for vcpu_set_reg and vcpu_get_reg, which
are necessary for kvm_psci_narrow_to_32bit further down in the same header.

Could the commit message be misattributing the fix to vcpu_has_feature instead
of the register accessors?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261007073537.2454351-1-suzuki.poulose@arm.com?part=3