All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
Cc: linux-security-module@vger.kernel.org
Subject: Re: [PATCH v5 2/8] landlock: Wrap per-layer access masks in struct layer_config
Date: Wed, 07 Oct 2026 10:10:16 +0000	[thread overview]
Message-ID: <sashiko-outbox-162841@kernel.org> (raw)
In-Reply-To: <20261007100255.1333386-3-mic@digikod.net>

> The domain layer FAM stores struct access_masks values directly, while a
> ruleset stores the equivalent single mutable value.  Per-category
> permissions need additional per-layer data beyond the handled-access
> bitfields.
> 
> Introduce struct layer_config as the common value type.  Keeping the
> handled bitfields in its .handled member leaves struct access_masks as a
> lightweight parameter type for functions that only need those bitfields,
> while the complete layer can be snapshotted with one assignment.
> 
> At this point struct layer_config only wraps the four-byte access_masks,
> so it does not grow the per-domain allocation: the maximum 16-entry FAM
> remains 64 bytes.
> 
> No functional change.
> 
> Cc: Günther Noack <gnoack@google.com>
> Reviewed-by: Günther Noack <gnoack@google.com>
> Reviewed-by: Tingmao Wang <m@maowtm.org>
> Signed-off-by: Mickaël Salaün <mic@digikod.net>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261007100255.1333386-1-mic@digikod.net?part=2


  reply	other threads:[~2026-10-07 10:10 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-07 10:02 [PATCH v5 0/8] Landlock: Namespace and capability control Mickaël Salaün
2026-10-07 10:02 ` [PATCH v5 1/8] landlock: Rename quiet_masks to quiet_access Mickaël Salaün
2026-10-07 10:09   ` sashiko-bot
2026-10-07 10:02 ` [PATCH v5 2/8] landlock: Wrap per-layer access masks in struct layer_config Mickaël Salaün
2026-10-07 10:10   ` sashiko-bot [this message]
2026-10-07 10:02 ` [PATCH v5 3/8] landlock: Enforce namespace use restrictions Mickaël Salaün
2026-10-07 10:15   ` sashiko-bot
2026-10-07 10:02 ` [PATCH v5 4/8] landlock: Enforce capability restrictions Mickaël Salaün
2026-10-07 10:11   ` sashiko-bot
2026-10-07 10:02 ` [PATCH v5 5/8] selftests/landlock: Add namespace restriction tests Mickaël Salaün
2026-10-07 10:23   ` sashiko-bot
2026-10-07 10:02 ` [PATCH v5 6/8] selftests/landlock: Add capability " Mickaël Salaün
2026-10-07 10:13   ` sashiko-bot
2026-10-07 10:02 ` [PATCH v5 7/8] samples/landlock: Add capability and namespace restriction support Mickaël Salaün
2026-10-07 10:11   ` sashiko-bot
2026-10-07 10:02 ` [PATCH v5 8/8] landlock: Add documentation for capability and namespace restrictions Mickaël Salaün
2026-10-07 10:10   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-162841@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.