Re: [RFC PATCH v3 3/4] md: use struct mdu_array_info64 for SET_ARRAY_INFO

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] md: format string mismatch for major_version in pr_warn
--

commit 4b1b8271e62fda3b747c4ac07bffdb6f7582ebcf
Author: Abd-Alrhman Masalkhi <abd.masalkhi@gatech.edu>

md: use struct mdu_array_info64 for SET_ARRAY_INFO

The md control device passes array information as struct mdu_array_info64.
Make md_set_array_info() and update_array_info() take the new struct
mdu_array_info64, so that the md control device and the old SET_ARRAY_INFO
ioctl can share them. md_set_array_info() no longer checks for a negative
major_version since the field is unsigned now.

> diff --git a/drivers/md/md.c b/drivers/md/md.c
> index be1634ae1d09c..63b9468285b09 100644
> --- a/drivers/md/md.c
> +++ b/drivers/md/md.c
> @@ -7904,12 +7904,11 @@ static int set_bitmap_file(struct mddev *mddev, int fd)
>   *  The minor and patch _version numbers are also kept incase the
>   *  super_block handler wishes to interpret them.
>   */
> -int md_set_array_info(struct mddev *mddev, struct mdu_array_info_s *info)
> +int md_set_array_info(struct mddev *mddev, struct mdu_array_info64 *info)
>  {
>  	if (info->raid_disks == 0) {
>  		/* just setting version number for superblock loading */
> -		if (info->major_version < 0 ||
> -		    info->major_version >= ARRAY_SIZE(super_types) ||
> +		if (info->major_version >= ARRAY_SIZE(super_types) ||
>  		    super_types[info->major_version].name == NULL) {
>  			/* maybe try to auto-load a module? */
>  			pr_warn("md: superblock version %d not known\n",
>  				info->major_version);

[Severity: Low]
Is there a format string mismatch here?

Since info->major_version is now an unsigned __u32 type, should the format
specifier in this warning be updated from %d to %u? A large unsigned value
provided by userspace could incorrectly print as a negative number.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261007115104.13884-1-abd.masalkhi@gatech.edu?part=3