Re: [PATCH v7 10/16] iommufd: Add the vdevice TSM request ioctl

[sashiko-bot@kernel.org]

> A VMM needs to forward guest-originated TSM commands to the TSM
> implementation managing an assigned device. The IOMMUFD vdevice
> identifies that device within its vIOMMU and provides the appropriate
> dispatch point.
> 
> Add IOMMU_VDEVICE_TSM_REQ to send an opaque request to a vdevice and
> optionally return a response. Define common operation and guest
> architecture identifiers for CCA, SEV and TDX requests.
> 
> Let vdevice providers declare the TVM architecture and supported operations
> in a u64 mask. Check these capabilities before dispatch. Define a
> one-past-last operation value and assert that every operation fits in the
> mask; reject out-of-range userspace values before indexing it.
> 
> The ioctl return value reports errors or the number of unused buffer bytes,
> while tsm_code carries the TSM-specific result. Use userspace pointers for
> the internal request and response buffers, and u32 lengths matching the
> UAPI. Reject lengths above INT_MAX so successful residues fit in the
> ioctl's int return value.
> 
> Cc: jgg@ziepe.ca
> Cc: kevin.tian@intel.com
> Cc: joro@8bytes.org
> Cc: will@kernel.org
> Cc: robin.murphy@arm.com
> Signed-off-by: Aneesh Kumar K.V (Arm) <aneesh.kumar@kernel.org>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261008055955.4014342-1-aneesh.kumar@kernel.org?part=10