Re: [PATCH v7 2/7] bus: mhi: Move Sahara protocol driver under MHI host client drivers

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] kconfig: MHI_SAHARA missing select WANT_DEV_COREDUMP
--

commit cc1e20cb4bdaa51fb38cee82d4db3c559fb1e1d9
Author: Kishore Batta <kishore.batta@oss.qualcomm.com>

bus: mhi: Move Sahara protocol driver under MHI host client drivers

This patch moves the Sahara protocol driver from the QAIC accelerator
subsystem to the MHI host client drivers to allow reuse. It sets up a new
Kconfig hierarchy and converts the driver to use module_mhi_driver().

> diff --git a/drivers/bus/mhi/host/clients/sahara/Kconfig b/drivers/bus/mhi/host/clients/sahara/Kconfig
> new file mode 100644
> index 0000000000000..f1fc7013a2dee
> --- /dev/null
> +++ b/drivers/bus/mhi/host/clients/sahara/Kconfig
> @@ -0,0 +1,15 @@
> +config MHI_SAHARA
> +	tristate "Sahara protocol driver"
> +	depends on MHI_BUS

[Severity: Medium]
Does this new Kconfig entry also need to select WANT_DEV_COREDUMP?

Since the Sahara driver is now an independent module, if it is built in a
configuration where DRM_ACCEL_QAIC is disabled, DEV_COREDUMP may not be
selected.

When DEV_COREDUMP is not set, the dev_coredumpv() call in
sahara_parse_dump_image() falls back to an inline stub that silently frees
the memory dump without exposing it.

Adding select WANT_DEV_COREDUMP here would ensure the diagnostic features
advertised in the help text remain functional regardless of whether other
drivers happen to enable the core dump framework.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261008-sahara_protocol_new_v2-v7-0-90d278bd7414@oss.qualcomm.com?part=2