All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Juergen Gross" <jgross@suse.com>
Cc: linux-hwmon@vger.kernel.org, dri-devel@lists.freedesktop.org,
	virtualization@lists.linux.dev,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Eugenio Perez" <eperezma@redhat.com>,
	linux-pci@vger.kernel.org, linux-gpio@vger.kernel.org,
	cassel@kernel.org, linux-ide@vger.kernel.org,
	linux-perf-users@vger.kernel.org, kvm@vger.kernel.org,
	dlemoal@kernel.org, linux-hyperv@vger.kernel.org
Subject: Re: [PATCH v4 12/13] treewide: convert rdmsrq() from a macro to an inline function
Date: Thu, 08 Oct 2026 07:37:14 +0000	[thread overview]
Message-ID: <sashiko-outbox-163770@kernel.org> (raw)
In-Reply-To: <20261008071839.2247074-13-jgross@suse.com>

> Today rdmsrq() is a macro using its second parameter as the target for
> storing the read MSR value.
> 
> Convert rdmsrq() to an inline function returning the MSR value.
> 
> The users have been converted using the following semantic patch:
> 
>   // Options: --include-headers
> 
>   virtual patch
>   virtual report
> 
>   @@
>   expression msr, val;
>   @@
>   (
>   - rdmsrq(msr,val)
>   + val = rdmsrq(msr)
>   )
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261008071839.2247074-1-jgross@suse.com?part=12


  reply	other threads:[~2026-10-08  7:37 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-08  7:18 [PATCH v4 00/13] x86/msr: Drop 32-bit MSR interfaces Juergen Gross
2026-10-08  7:18 ` Juergen Gross
2026-10-08  7:18 ` [PATCH v4 03/13] x86/msr: Remove rdmsr_safe() Juergen Gross
2026-10-08  7:29   ` sashiko-bot
2026-10-08  7:18 ` [PATCH v4 04/13] drivers/ata: Stop using 32-bit MSR interfaces Juergen Gross
2026-10-08  7:18 ` [PATCH v4 05/13] agp/nvidia: " Juergen Gross
2026-10-08  7:18 ` [PATCH v4 06/13] fbdev/geode: " Juergen Gross
2026-10-08  7:18 ` [PATCH v4 07/13] hw_random/via-rng: " Juergen Gross
2026-10-08  7:18 ` [PATCH v4 08/13] drivers/gpio: " Juergen Gross
2026-10-08  7:18 ` [PATCH v4 10/13] x86/msr: Remove wrmsr() Juergen Gross
2026-10-08  7:30   ` sashiko-bot
2026-10-08  7:18 ` [PATCH v4 11/13] x86/msr: Remove rdmsr() Juergen Gross
2026-10-08  7:31   ` sashiko-bot
2026-10-08  7:18 ` [PATCH v4 12/13] treewide: convert rdmsrq() from a macro to an inline function Juergen Gross
2026-10-08  7:18   ` Juergen Gross
2026-10-08  7:37   ` sashiko-bot [this message]
2026-10-12  6:00   ` K Prateek Nayak
2026-10-12  6:00     ` K Prateek Nayak
2026-10-08  7:18 ` [PATCH v4 13/13] x86/msr: Simplify some rdmsrq() use cases Juergen Gross
2026-10-08  7:31   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-163770@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=cassel@kernel.org \
    --cc=dlemoal@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=eperezma@redhat.com \
    --cc=jgross@suse.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-hyperv@vger.kernel.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=virtualization@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.