From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E54C9CA600B for ; Thu, 8 Oct 2026 07:38:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date:References: In-Reply-To:Cc:To:Subject:From:Message-ID:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tixjPk863VOBIbUMLiH9FmUgZ6YKLQ0neQrqpR/6VKg=; b=ayDiOLGGiacTDw 6a9Ps0ajONP5244cqT0hu3MInL2TaV2zhQmVdpnJMOyK2QFmy5hOCx5m3N1IPXtUlo7Ss4Ukr0Tgq VapY/Uh6fpD98lG37iKT0pLZMpS/cT2yZMYSafDdeuYNr5N1+iDXNpEvYaKwpxT2/2ZN7sSN4ob5L l4rJrglxZQLJdalfU0dfKabFVOED3UfWMo2CisGfH0lOwm8QDJUti/FaKiB7+h1gbnlEJeVmoTW16 g72eiyxPh0YYQCPIMWY//VI4P7emmxFBOUyeV6p8Jyl2uYr75OTosIQW9RzF1xCwZBn8bfxsk7Tv9 2qxTzpTFD+ppnNPuBDVg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xEii7-00000003m8A-24gB; Thu, 08 Oct 2026 07:38:39 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xEii6-00000003m7c-0mLh for linux-phy@lists.infradead.org; Thu, 08 Oct 2026 07:38:38 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 8CEEB40510; Thu, 8 Oct 2026 07:38:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ECAB11F000FF; Thu, 8 Oct 2026 07:38:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791445117; bh=fD5/VzPOP285tieFjJYzmjPCcIpVKLL0xt86IeL/mic=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=ioZJo469BuFcNtLdK0rPqLD7dzSO/3TIgGQb7q2wxp+bPMqvE3GoOrFb1yW9eegCR VrpSuJ923URVcx8A8eVvU1I5soMbUEdC1VNwBMunJu02XOJCm80LOj/QRvScirAG+P TZpzgihG2sCEx5PdJnYpfkujuxHvK6pzWQAspV1YZrwQ/O0TGsyjobqoLSjHjPZVKp MVuGn01KpjZCYPVuk+CCNmlexBJSE4dlm0kdi9Q4/NBdv0C4wKyww2CRBrNPQ5j+II dIOcR2PPlNQJw3k+SaxlCmi3b9ruTe9HsVeqNqbOFpEkskhdcxwnvtPATvL0tQOPyC g2NY1tihtfGlg== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v19 10/12] arm64: dts: qcom: kaanapali: Add CAMSS and CSIPHY block definitions To: "Hangxiang Ma" Cc: neil.armstrong@linaro.org, robh@kernel.org, olteanv@gmail.com, conor+dt@kernel.org, vkoul@kernel.org, media-ci@linuxtv.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org In-Reply-To: <20261008-kaanapali-camss-v19-10-b2c583ef50e0@oss.qualcomm.com> References: <20261008-kaanapali-camss-v19-0-b2c583ef50e0@oss.qualcomm.com> <20261008-kaanapali-camss-v19-10-b2c583ef50e0@oss.qualcomm.com> Date: Thu, 08 Oct 2026 07:38:36 +0000 X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW0hpZ2hdIGR0czogbWlzc2luZyBT b0MtaW50ZXJuYWwgT0YgZ3JhcGggbGlua3MgYmV0d2VlbiBjYW1zcyBhbmQgc3RhbmRhbG9uZSBj c2lwaHkgbm9kZXMKLS0KCmNvbW1pdCBhNjM2ODViMDc3ZTgwZmNiYjYxZDU4YjA0ZDQzN2FkZGVi Mjc3YTkzCkF1dGhvcjogSGFuZ3hpYW5nIE1hIDxoYW5neGlhbmcubWFAb3NzLnF1YWxjb21tLmNv bT4KCmFybTY0OiBkdHM6IHFjb206IGthYW5hcGFsaTogQWRkIENBTVNTIGFuZCBDU0lQSFkgYmxv Y2sgZGVmaW5pdGlvbnMKClRoaXMgY29tbWl0IGRlc2NyaWJlcyB0aGUgQ0FNU1MgYW5kIENTSVBI WSBibG9ja3Mgb24gdGhlIEthYW5hcGFsaSBTb0MuCkl0IGFkZHMgNiBDU0lQSFlzLCAzIFRQR3Ms IDMgQ1NJRHMsIDIgQ1NJRCBMaXRlcywgMyBWRkVzLCBhbmQgMiBWRkUgTGl0ZXMKdG8gZW5hYmxl IGNhbWVyYSBwaXBlbGluZXMgb24gYm9hcmQgZGV2aWNlIHRyZWVzLgoKPiBkaWZmIC0tZ2l0IGEv YXJjaC9hcm02NC9ib290L2R0cy9xY29tL2thYW5hcGFsaS5kdHNpIGIvYXJjaC9hcm02NC9ib290 L2R0cy9xY29tL2thYW5hcGFsaS5kdHNpCj4gaW5kZXggZTQ4YTE3OWQwNzIyMC4uN2U1MTA2ODY1 ZTdlZSAxMDA2NDQKPiAtLS0gYS9hcmNoL2FybTY0L2Jvb3QvZHRzL3Fjb20va2FhbmFwYWxpLmR0 c2kKPiArKysgYi9hcmNoL2FybTY0L2Jvb3QvZHRzL3Fjb20va2FhbmFwYWxpLmR0c2kKClsgLi4u IF0KCj4gQEAgLTM1OTcsNiArMzU5OCwzMDcgQEAgdXNiX2RwX3FtcHBoeV9kcF9pbjogZW5kcG9p bnQgewo+ICAJCQl9Owo+ICAJCX07Cj4gIAo+ICsJCWNhbXNzOiBpc3BAOTI1MzAwMCB7Cj4gKwkJ CWNvbXBhdGlibGUgPSAicWNvbSxrYWFuYXBhbGktY2Ftc3MiOwoKWyAuLi4gXQoKPiArCQkJc3Rh dHVzID0gImRpc2FibGVkIjsKPiArCj4gKwkJCXBvcnRzIHsKPiArCQkJCSNhZGRyZXNzLWNlbGxz ID0gPDE+Owo+ICsJCQkJI3NpemUtY2VsbHMgPSA8MD47Cj4gKwo+ICsJCQkJcG9ydEAwIHsKPiAr CQkJCQlyZWcgPSA8MD47Cj4gKwkJCQl9Owo+ICsKPiArCQkJCXBvcnRAMSB7Cj4gKwkJCQkJcmVn ID0gPDE+Owo+ICsJCQkJfTsKCltTZXZlcml0eTogSGlnaF0KV2lsbCB0aGUgQ0FNU1MgZHJpdmVy IGJlIGFibGUgdG8gZmluZCB0aGUgQ1NJUEhZIGRldmljZXMgd2l0aCB0aGVzZSBlbXB0eQpwb3J0 IGRlZmluaXRpb25zPwoKVGhlIENBTVNTIGRyaXZlciAobXNtX2NzaXBoeV9zdWJkZXZfaW5pdCBp biBjYW1zcy1jc2lwaHkuYykgZGlzY292ZXJzIGl0cwpQSFlzIGJ5IHRyYXZlcnNpbmcgdGhlIE9G IGdyYXBoIHVzaW5nIG9mX2dyYXBoX2dldF9lbmRwb2ludF9ieV9yZWdzIG9uIHRoZQpjYW1zcyBu b2RlJ3MgcG9ydHMsIGZvbGxvd2luZyBpdCB0byB0aGUgcmVtb3RlIGVuZHBvaW50J3MgcGFyZW50 LCBhbmQgY2FsbGluZwpkZXZtX3BoeV9nZXRfYnlfb2Zfbm9kZS4KCkJlY2F1c2UgdGhlc2UgcG9y dHMgbGFjayBlbmRwb2ludCBkZWZpbml0aW9ucyBsaW5raW5nIGJhY2sgdG8gdGhlIENTSVBIWQpv dXRwdXRzLCB0aGUgbG9va3VwIHdpbGwgcmV0dXJuIE5VTEwgYW5kIHNpbGVudGx5IHNraXAgUEhZ IGluaXRpYWxpemF0aW9uLgpUaGlzIGxlYXZlcyB0aGUgcGh5IHVuaW5pdGlhbGl6ZWQgYW5kIHBy ZXZlbnRzIHRoZSBQSFlzIGZyb20gcG93ZXJpbmcgb24KZHVyaW5nIHN0cmVhbWluZy4KClsgLi4u IF0KCj4gKwkJCX07Cj4gKwkJfTsKPiArCj4gKwkJY3NpcGh5MDogcGh5QDk1MjMwMDAgewo+ICsJ CQljb21wYXRpYmxlID0gInFjb20sa2FhbmFwYWxpLWNzaTItcGh5IjsKPiArCQkJcmVnID0gPDB4 MCAweDA5NTIzMDAwIDB4MCAweDIwMDA+Owo+ICsKPiArCQkJY2xvY2tzID0gPCZjYW1jYyBDQU1f Q0NfQ1NJUEhZMF9DTEs+LAoKW1NldmVyaXR5OiBIaWdoXQpEb2VzIHRoaXMgc3RhbmRhbG9uZSBj c2lwaHkwIG5vZGUgYWxzbyBuZWVkIGEgcG9ydHMgc3RydWN0dXJlIHRvIGRlZmluZSBpdHMKQ0FN U1Mgb3V0cHV0IGVuZHBvaW50PwoKV2l0aG91dCBhIHBvcnRzIGRlZmluaXRpb24gaW4gdGhlIGNz aXBoeSBub2RlcywgdGhlIE9GIGdyYXBoIHRyYXZlcnNhbCBmcm9tCnRoZSBjYW1zcyBub2RlIGNh bm5vdCByZXNvbHZlIHRoZSByZW1vdGUgZW5kcG9pbnQsIGJyZWFraW5nIHRoZSBpbnRlcm5hbApT b0Mgcm91dGluZyByZXF1aXJlZCB0byBpbml0aWFsaXplIHRoZSBQSFlzLgoKU2luY2UgdGhlc2Ug YXJlIGhhcmR3aXJlZCBTb0MtaW50ZXJuYWwgY29ubmVjdGlvbnMgYmV0d2VlbiB0aGUgUEhZIG91 dHB1dAphbmQgdGhlIENBTVNTIGlucHV0LCBzaG91bGRuJ3QgdGhleSBiZSBkZWZpbmVkIGhlcmUg aW4gdGhlIC5kdHNpIHJhdGhlcgp0aGFuIGZvcmNpbmcgZG93bnN0cmVhbSBib2FyZCAuZHRzIGZp bGVzIHRvIG1hbnVhbGx5IGNvbnN0cnVjdCB0aGUgaW50ZXJuYWwKU29DIHJvdXRpbmc/CgpbIC4u LiBdCgotLSAKU2FzaGlrbyBBSSByZXZpZXcgwrcgaHR0cHM6Ly9zYXNoaWtvLmRldi8jL3BhdGNo c2V0LzIwMjYxMDA4LWthYW5hcGFsaS1jYW1zcy12MTktMC1iMmM1ODNlZjUwZTBAb3NzLnF1YWxj b21tLmNvbT9wYXJ0PTEwCgotLSAKbGludXgtcGh5IG1haWxpbmcgbGlzdApsaW51eC1waHlAbGlz dHMuaW5mcmFkZWFkLm9yZwpodHRwczovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0 aW5mby9saW51eC1waHkK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A013A3B7B93 for ; Thu, 8 Oct 2026 07:38:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791445120; cv=none; b=l+h18pzBLhvmwpd1clhQFgytQ0OrvMxY3q2sr06vV2lqA9cwB5AHgZlA785UIJ7fauksP9dAQedb3feJ9X4jrXt68fGZ7RxjAJvz9kWv1yggm/69JUXbxTiJ21mViLGwEQr2V7ArHAXbaLn0Dzih+g5wBVTEefAOlCvHwFTeEUk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791445120; c=relaxed/simple; bh=1lb8xbW38NGNB9zgrvSXbPga7sobIId/EfHZGsRYr/M=; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type: Date; b=AdW5nom4Ooqx1zfHghhNhoSRAFsZgQwg5QlHyqldZqP6V+d/iUn1DNVEq3TrDJ7XoH7fFIKGyj+SsE6vSw5eYTKQk2xQbWRf5YiB4UbnrBYB/cEYlTyF+HSl/WXCRMUzTvDoNZIt5EcV0fxAhg08xgLveAyAQmdFEsH08TczLwg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ioZJo469; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ioZJo469" Received: by smtp.kernel.org (Postfix) with ESMTPSA id ECAB11F000FF; Thu, 8 Oct 2026 07:38:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791445117; bh=fD5/VzPOP285tieFjJYzmjPCcIpVKLL0xt86IeL/mic=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=ioZJo469BuFcNtLdK0rPqLD7dzSO/3TIgGQb7q2wxp+bPMqvE3GoOrFb1yW9eegCR VrpSuJ923URVcx8A8eVvU1I5soMbUEdC1VNwBMunJu02XOJCm80LOj/QRvScirAG+P TZpzgihG2sCEx5PdJnYpfkujuxHvK6pzWQAspV1YZrwQ/O0TGsyjobqoLSjHjPZVKp MVuGn01KpjZCYPVuk+CCNmlexBJSE4dlm0kdi9Q4/NBdv0C4wKyww2CRBrNPQ5j+II dIOcR2PPlNQJw3k+SaxlCmi3b9ruTe9HsVeqNqbOFpEkskhdcxwnvtPATvL0tQOPyC g2NY1tihtfGlg== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v19 10/12] arm64: dts: qcom: kaanapali: Add CAMSS and CSIPHY block definitions Reply-To: sashiko-reviews@lists.linux.dev To: "Hangxiang Ma" Cc: neil.armstrong@linaro.org, robh@kernel.org, olteanv@gmail.com, conor+dt@kernel.org, vkoul@kernel.org, media-ci@linuxtv.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org In-Reply-To: <20261008-kaanapali-camss-v19-10-b2c583ef50e0@oss.qualcomm.com> References: <20261008-kaanapali-camss-v19-0-b2c583ef50e0@oss.qualcomm.com> <20261008-kaanapali-camss-v19-10-b2c583ef50e0@oss.qualcomm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Thu, 08 Oct 2026 07:38:36 +0000 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [High] dts: missing SoC-internal OF graph links between camss and standal= one csiphy nodes -- commit a63685b077e80fcbb61d58b04d437addeb277a93 Author: Hangxiang Ma arm64: dts: qcom: kaanapali: Add CAMSS and CSIPHY block definitions This commit describes the CAMSS and CSIPHY blocks on the Kaanapali SoC. It adds 6 CSIPHYs, 3 TPGs, 3 CSIDs, 2 CSID Lites, 3 VFEs, and 2 VFE Lites to enable camera pipelines on board device trees. > diff --git a/arch/arm64/boot/dts/qcom/kaanapali.dtsi b/arch/arm64/boot/dt= s/qcom/kaanapali.dtsi > index e48a179d07220..7e5106865e7ee 100644 > --- a/arch/arm64/boot/dts/qcom/kaanapali.dtsi > +++ b/arch/arm64/boot/dts/qcom/kaanapali.dtsi [ ... ] > @@ -3597,6 +3598,307 @@ usb_dp_qmpphy_dp_in: endpoint { > }; > }; > =20 > + camss: isp@9253000 { > + compatible =3D "qcom,kaanapali-camss"; [ ... ] > + status =3D "disabled"; > + > + ports { > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + > + port@0 { > + reg =3D <0>; > + }; > + > + port@1 { > + reg =3D <1>; > + }; [Severity: High] Will the CAMSS driver be able to find the CSIPHY devices with these empty port definitions? The CAMSS driver (msm_csiphy_subdev_init in camss-csiphy.c) discovers its PHYs by traversing the OF graph using of_graph_get_endpoint_by_regs on the camss node's ports, following it to the remote endpoint's parent, and calli= ng devm_phy_get_by_of_node. Because these ports lack endpoint definitions linking back to the CSIPHY outputs, the lookup will return NULL and silently skip PHY initialization. This leaves the phy uninitialized and prevents the PHYs from powering on during streaming. [ ... ] > + }; > + }; > + > + csiphy0: phy@9523000 { > + compatible =3D "qcom,kaanapali-csi2-phy"; > + reg =3D <0x0 0x09523000 0x0 0x2000>; > + > + clocks =3D <&camcc CAM_CC_CSIPHY0_CLK>, [Severity: High] Does this standalone csiphy0 node also need a ports structure to define its CAMSS output endpoint? Without a ports definition in the csiphy nodes, the OF graph traversal from the camss node cannot resolve the remote endpoint, breaking the internal SoC routing required to initialize the PHYs. Since these are hardwired SoC-internal connections between the PHY output and the CAMSS input, shouldn't they be defined here in the .dtsi rather than forcing downstream board .dts files to manually construct the internal SoC routing? [ ... ] --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261008-kaanapali-= camss-v19-0-b2c583ef50e0@oss.qualcomm.com?part=3D10