Re: [PATCH] ext4: test reads after a failed zeroout of an unwritten extent

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] fs/ext4: Script submitted to wrong repository (fstests vs kernel)
- [Medium] ext4/xfstests: Typo in _require_scratch_ext4_feature_enabled function call
--

commit 15df6b5040afb28bc9e8fcc362919219d21014ba
Author: Daejun Park <daejun7.park@samsung.com>

ext4: test reads after a failed zeroout of an unwritten extent

This commit adds a new test script to verify that reading blocks from an
unwritten extent returns zeroes after a failed zeroout operation. It uses
dm-error to simulate the failure and ensures ext4 doesn't cache the unzeroed
blocks.

Link: https://lore.kernel.org/r/20261008-ext4-fc-zeroout-v2-1-55cab1e24fa3@samsung.com

> diff --git a/tests/ext4/309 b/tests/ext4/309
> new file mode 100755
> index 0000000000000..1fafd58263577
> --- /dev/null
> +++ b/tests/ext4/309
> @@ -0,0 +1,87 @@
> +#! /bin/bash
> +# SPDX-License-Identifier: GPL-2.0
> +# Copyright (c) 2026 Samsung Electronics Co., Ltd. All Rights Reserved.
> +#
> +# FS QA Test No. 309
[ ... ]
> +. ./common/preamble
> +_begin_fstest auto quick rw prealloc eio

[Severity: Medium]
Does this script belong in the fstests repository instead of the Linux kernel
tree? 

The use of the common preamble and _begin_fstest demonstrates a dependency
on the xfstests framework. Applying this patch to the kernel tree will
result in a non-functional script with unresolved dependencies.

[ ... ]
> +_require_scratch
> +_require_dm_target error
> +_require_xfs_io_command "falloc"
> +_require_xfs_io_command "fiemap"
> +_require_scratch_ext4_feature_enabled "extent"

[Severity: Medium]
Is there a typo in this function call?

The function _require_scratch_ext4_feature_enabled does not appear to exist
and should likely be _require_scratch_ext4_feature. This requirement check
will fail silently (printing an error but continuing execution), potentially
causing the test to run on unsupported configurations.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261008-ext4-zeroout-eio-test-v1-1-9bb66deaf646@samsung.com?part=1