From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E2F353EBF07 for ; Thu, 8 Oct 2026 08:26:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791448018; cv=none; b=P7Gqd8Rlj7pLEKyHSbQEp4Q0r7OZ6niSL/D9Ve5DGvnDYDL8MVFoD96/HkxQqk6F9VN8LAUu5pUeVllnWCAkMrpi01JGcfKIM0orpBiMRnI22ibn5n6fEJr1YfjNOJypmEEAXyLHOniMMYZTgkAnBnruQIgqXxSPB4dqs41lNas= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791448018; c=relaxed/simple; bh=eqofWnF6Ucn8NB/to8k2Ig8TXYIgkb/Yc4UBILZCjN4=; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type: Date; b=EI4TfBJKjh4UyzJe7cwNocyIbYbFulH4afoNzN/eRUQXahffwEVyF86A5R0L7L+fTAtrwUzAex3iZbDy/XfX0Cg2I8OGbuqCceY3nyBCrHLjQEvOgYmokgFbeY1s3X+3wFGSMV3HT9LKqkoJetLLMQYDexD5MhZelhQEkZPPF7o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QAQ/E9GA; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QAQ/E9GA" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 50B1D1F000FF; Thu, 8 Oct 2026 08:26:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791448016; bh=QbwiNqUlryiAkjLGdwSvFVBVtT5S7hT5G1vHdMZPOqA=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=QAQ/E9GAieRxTo9U6QIWxkRvqIlKpB5xPyCuBh1GUV/wOjCVMiKHmJXR8al2GW7RA 5OgZJmBk0QV1Sd+dy/byHYvHmX1Hi9DBAStFjt7G3rXp6rSe31p3/b+p8pPHQ2PlW8 SwdYbllXa0fcO35co4INF6iNVLSd3y+M8SxYYLWlwsQWJLO4fDW/n1jFftK1apo/Y5 y/FluAb5DsyOtGLSJ0nzLFkTPU8I/acg9hCDpOW0SZUBLinAcVylM2rM01pDbsLgUC XAC1MPdsxc8owl+GqOtMA1Y+u/Y4qj8tK18IL+6SGW04fESYmo4NN1n7KBAmR6+0c/ FBrmNFfq09KYQ== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [RFC PATCH v2 3/7] dt-bindings: net: amlogic,meson-dwmac: add amlogic,t7-dwmac Reply-To: sashiko-reviews@lists.linux.dev To: "Lucas Tanure" Cc: linux-amlogic@lists.infradead.org, neil.armstrong@linaro.org, devicetree@vger.kernel.org, conor+dt@kernel.org, robh@kernel.org In-Reply-To: <20261007082627.63807-4-tanure@linux.com> References: <20261007082627.63807-1-tanure@linux.com> <20261007082627.63807-4-tanure@linux.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Thu, 08 Oct 2026 08:26:56 +0000 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Medium] net: stmmac: silent bitfield truncation of tx-internal-delay-ps -- commit df8d2ca7732ce1f0cf81bbfee0085a28dfb7f50f Author: Lucas Tanure dt-bindings: net: amlogic,meson-dwmac: add amlogic,t7-dwmac The T7 has the same ethernet glue as the G12A, but the controller reaches memory through a pipeline stage that this SoC inserts in the bus path. That stage has a gate of its own, which no other member of the family has, and nothing else in Linux claims it. It is therefore switched off as unused, and the port can then no longer finish a transfer. Describing it needs a fourth clock, and the fourth clock of the existing list drives the timing adjustment logic, which the T7 never uses. So the T7 gets a list of its own with the gate in that place, under the name the SD and eMMC controllers already use. Assisted-by: LLM Signed-off-by: Lucas Tanure > diff --git a/Documentation/devicetree/bindings/net/amlogic,meson-dwmac.ya= ml b/Documentation/devicetree/bindings/net/amlogic,meson-dwmac.yaml > index 90ef79161ab1a..96118b4d15609 100644 > --- a/Documentation/devicetree/bindings/net/amlogic,meson-dwmac.yaml > +++ b/Documentation/devicetree/bindings/net/amlogic,meson-dwmac.yaml [ ... ] > @@ -57,6 +58,47 @@ allOf: > - const: clkin1 > - const: timing-adjustment > =20 > + # The T7 applies the RGMII RX delay through PRG_ETH1 and never enables= the > + # timing adjustment logic, so it has no timing-adjustment clock. What = it does > + # need is the gate of the pipeline stage the controller reaches DRAM t= hrough. > + - if: > + properties: > + compatible: > + contains: > + const: amlogic,t7-dwmac > + then: > + properties: > + clocks: > + items: > + - description: GMAC main clock > + - description: First parent clock of the internal mux > + - description: Second parent clock of the internal mux > + - description: > + clock of the pipeline stage inserted in the bus path bet= ween > + the controller and the DRAM. Without it, the controller = cannot > + complete DMA transfers. > + > + clock-names: > + items: > + - const: stmmaceth > + - const: clkin0 > + - const: clkin1 > + - const: pipeline > + > + # Delay definitions for Meson8b and newer (including T7) > + - if: > + properties: > + compatible: > + contains: > + enum: > + - amlogic,meson8b-dwmac > + - amlogic,meson8m2-dwmac > + - amlogic,meson-gxbb-dwmac > + - amlogic,meson-axg-dwmac > + - amlogic,meson-g12a-dwmac > + - amlogic,t7-dwmac > + then: > + properties: > amlogic,tx-delay-ns: > enum: [0, 2, 4, 6] > default: 2 [Severity: Medium] Does the schema lack constraints for tx-internal-delay-ps? The driver reads tx-internal-delay-ps from the device tree and assigns it without any bounds checking: drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c:meson8b_dwmac_probe() { ... if (!of_property_read_u32(pdev->dev.of_node, "tx-internal-delay-ps", &tx_delay_ps)) dwmac->tx_delay_ns =3D tx_delay_ps / 1000; ... } Because it is not validated, a value >=3D 8000 (8ns) will be silently trunc= ated by the 2-bit PRG_ETH0_TXDLY_MASK: drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c:meson8b_init_rgmii_dela= ys() { ... tx_dly_config =3D FIELD_PREP(PRG_ETH0_TXDLY_MASK, dwmac->tx_delay_ns >> 1); ... } Because the schema does not define constraints for tx-internal-delay-ps and the driver does not validate the bounds, a misconfigured DTS will silen= tly fail and misconfigure the hardware. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261007082627.6380= 7-1-tanure@linux.com?part=3D3 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D004ECA6007 for ; Thu, 8 Oct 2026 08:27:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date:References: In-Reply-To:Cc:To:Subject:From:Message-ID:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=h8w9KbQMD3K1AVlM37QwHdXNXxKhi3PYaO9yo8hl9U0=; b=krsM6K7wFyZEZI Fn+ff2363F8Ubjt3L5UADkOJKRpHrcAtZ5tfxNNtCsjtLLVicFP6HlhIfTXQsq/1507baC4knhsKk YKDwe4bIvChz5RaCOT1PSiZio4kfWz7hsZr4TocIgGW3bSDfX119GfMNUNa103FSrPvtBNPl8jCm+ CfqX4oxZjjS85sB3P91p70c8DeTiPC6X9GldtjvQH2ZVYPLWsHK3n3r9WFp3xjGwfHHpH9UHSsOYH DKmXFg+x2ZRKv81vpoY/yxfsd+NYoSo44DRyj3bqdaEo2Ml+Oxn2AiIuw6fx4dCBrCvHcFjYH4+xP WdE3lxPFWjunztTiY4kQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xEjSu-00000003reD-1nBE; Thu, 08 Oct 2026 08:27:00 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xEjSs-00000003rdk-3nmF for linux-amlogic@lists.infradead.org; Thu, 08 Oct 2026 08:26:59 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id CEDE7601EF; Thu, 8 Oct 2026 08:26:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 50B1D1F000FF; Thu, 8 Oct 2026 08:26:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791448016; bh=QbwiNqUlryiAkjLGdwSvFVBVtT5S7hT5G1vHdMZPOqA=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=QAQ/E9GAieRxTo9U6QIWxkRvqIlKpB5xPyCuBh1GUV/wOjCVMiKHmJXR8al2GW7RA 5OgZJmBk0QV1Sd+dy/byHYvHmX1Hi9DBAStFjt7G3rXp6rSe31p3/b+p8pPHQ2PlW8 SwdYbllXa0fcO35co4INF6iNVLSd3y+M8SxYYLWlwsQWJLO4fDW/n1jFftK1apo/Y5 y/FluAb5DsyOtGLSJ0nzLFkTPU8I/acg9hCDpOW0SZUBLinAcVylM2rM01pDbsLgUC XAC1MPdsxc8owl+GqOtMA1Y+u/Y4qj8tK18IL+6SGW04fESYmo4NN1n7KBAmR6+0c/ FBrmNFfq09KYQ== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [RFC PATCH v2 3/7] dt-bindings: net: amlogic,meson-dwmac: add amlogic,t7-dwmac To: "Lucas Tanure" Cc: linux-amlogic@lists.infradead.org, neil.armstrong@linaro.org, devicetree@vger.kernel.org, conor+dt@kernel.org, robh@kernel.org In-Reply-To: <20261007082627.63807-4-tanure@linux.com> References: <20261007082627.63807-1-tanure@linux.com> <20261007082627.63807-4-tanure@linux.com> Date: Thu, 08 Oct 2026 08:26:56 +0000 X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW01lZGl1bV0gbmV0OiBzdG1tYWM6 IHNpbGVudCBiaXRmaWVsZCB0cnVuY2F0aW9uIG9mIHR4LWludGVybmFsLWRlbGF5LXBzCi0tCgpj b21taXQgZGY4ZDJjYTc3MzJjZTFmMGNmODFiYmZlZTAwODVhMjhkZmI3ZjUwZgpBdXRob3I6IEx1 Y2FzIFRhbnVyZSA8dGFudXJlQGxpbnV4LmNvbT4KCmR0LWJpbmRpbmdzOiBuZXQ6IGFtbG9naWMs bWVzb24tZHdtYWM6IGFkZCBhbWxvZ2ljLHQ3LWR3bWFjCgpUaGUgVDcgaGFzIHRoZSBzYW1lIGV0 aGVybmV0IGdsdWUgYXMgdGhlIEcxMkEsIGJ1dCB0aGUgY29udHJvbGxlcgpyZWFjaGVzIG1lbW9y eSB0aHJvdWdoIGEgcGlwZWxpbmUgc3RhZ2UgdGhhdCB0aGlzIFNvQyBpbnNlcnRzIGluIHRoZQpi dXMgcGF0aC4gVGhhdCBzdGFnZSBoYXMgYSBnYXRlIG9mIGl0cyBvd24sIHdoaWNoIG5vIG90aGVy IG1lbWJlciBvZgp0aGUgZmFtaWx5IGhhcywgYW5kIG5vdGhpbmcgZWxzZSBpbiBMaW51eCBjbGFp bXMgaXQuIEl0IGlzIHRoZXJlZm9yZQpzd2l0Y2hlZCBvZmYgYXMgdW51c2VkLCBhbmQgdGhlIHBv cnQgY2FuIHRoZW4gbm8gbG9uZ2VyIGZpbmlzaCBhCnRyYW5zZmVyLgoKRGVzY3JpYmluZyBpdCBu ZWVkcyBhIGZvdXJ0aCBjbG9jaywgYW5kIHRoZSBmb3VydGggY2xvY2sgb2YgdGhlCmV4aXN0aW5n IGxpc3QgZHJpdmVzIHRoZSB0aW1pbmcgYWRqdXN0bWVudCBsb2dpYywgd2hpY2ggdGhlIFQ3IG5l dmVyCnVzZXMuIFNvIHRoZSBUNyBnZXRzIGEgbGlzdCBvZiBpdHMgb3duIHdpdGggdGhlIGdhdGUg aW4gdGhhdCBwbGFjZSwKdW5kZXIgdGhlIG5hbWUgdGhlIFNEIGFuZCBlTU1DIGNvbnRyb2xsZXJz IGFscmVhZHkgdXNlLgoKQXNzaXN0ZWQtYnk6IExMTQpTaWduZWQtb2ZmLWJ5OiBMdWNhcyBUYW51 cmUgPHRhbnVyZUBsaW51eC5jb20+Cgo+IGRpZmYgLS1naXQgYS9Eb2N1bWVudGF0aW9uL2Rldmlj ZXRyZWUvYmluZGluZ3MvbmV0L2FtbG9naWMsbWVzb24tZHdtYWMueWFtbCBiL0RvY3VtZW50YXRp b24vZGV2aWNldHJlZS9iaW5kaW5ncy9uZXQvYW1sb2dpYyxtZXNvbi1kd21hYy55YW1sCj4gaW5k ZXggOTBlZjc5MTYxYWIxYS4uOTYxMThiNGQxNTYwOSAxMDA2NDQKPiAtLS0gYS9Eb2N1bWVudGF0 aW9uL2RldmljZXRyZWUvYmluZGluZ3MvbmV0L2FtbG9naWMsbWVzb24tZHdtYWMueWFtbAo+ICsr KyBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9uZXQvYW1sb2dpYyxtZXNvbi1k d21hYy55YW1sClsgLi4uIF0KPiBAQCAtNTcsNiArNTgsNDcgQEAgYWxsT2Y6Cj4gICAgICAgICAg ICAgIC0gY29uc3Q6IGNsa2luMQo+ICAgICAgICAgICAgICAtIGNvbnN0OiB0aW1pbmctYWRqdXN0 bWVudAo+ICAKPiArICAjIFRoZSBUNyBhcHBsaWVzIHRoZSBSR01JSSBSWCBkZWxheSB0aHJvdWdo IFBSR19FVEgxIGFuZCBuZXZlciBlbmFibGVzIHRoZQo+ICsgICMgdGltaW5nIGFkanVzdG1lbnQg bG9naWMsIHNvIGl0IGhhcyBubyB0aW1pbmctYWRqdXN0bWVudCBjbG9jay4gV2hhdCBpdCBkb2Vz Cj4gKyAgIyBuZWVkIGlzIHRoZSBnYXRlIG9mIHRoZSBwaXBlbGluZSBzdGFnZSB0aGUgY29udHJv bGxlciByZWFjaGVzIERSQU0gdGhyb3VnaC4KPiArICAtIGlmOgo+ICsgICAgICBwcm9wZXJ0aWVz Ogo+ICsgICAgICAgIGNvbXBhdGlibGU6Cj4gKyAgICAgICAgICBjb250YWluczoKPiArICAgICAg ICAgICAgY29uc3Q6IGFtbG9naWMsdDctZHdtYWMKPiArICAgIHRoZW46Cj4gKyAgICAgIHByb3Bl cnRpZXM6Cj4gKyAgICAgICAgY2xvY2tzOgo+ICsgICAgICAgICAgaXRlbXM6Cj4gKyAgICAgICAg ICAgIC0gZGVzY3JpcHRpb246IEdNQUMgbWFpbiBjbG9jawo+ICsgICAgICAgICAgICAtIGRlc2Ny aXB0aW9uOiBGaXJzdCBwYXJlbnQgY2xvY2sgb2YgdGhlIGludGVybmFsIG11eAo+ICsgICAgICAg ICAgICAtIGRlc2NyaXB0aW9uOiBTZWNvbmQgcGFyZW50IGNsb2NrIG9mIHRoZSBpbnRlcm5hbCBt dXgKPiArICAgICAgICAgICAgLSBkZXNjcmlwdGlvbjoKPiArICAgICAgICAgICAgICAgIGNsb2Nr IG9mIHRoZSBwaXBlbGluZSBzdGFnZSBpbnNlcnRlZCBpbiB0aGUgYnVzIHBhdGggYmV0d2Vlbgo+ ICsgICAgICAgICAgICAgICAgdGhlIGNvbnRyb2xsZXIgYW5kIHRoZSBEUkFNLiBXaXRob3V0IGl0 LCB0aGUgY29udHJvbGxlciBjYW5ub3QKPiArICAgICAgICAgICAgICAgIGNvbXBsZXRlIERNQSB0 cmFuc2ZlcnMuCj4gKwo+ICsgICAgICAgIGNsb2NrLW5hbWVzOgo+ICsgICAgICAgICAgaXRlbXM6 Cj4gKyAgICAgICAgICAgIC0gY29uc3Q6IHN0bW1hY2V0aAo+ICsgICAgICAgICAgICAtIGNvbnN0 OiBjbGtpbjAKPiArICAgICAgICAgICAgLSBjb25zdDogY2xraW4xCj4gKyAgICAgICAgICAgIC0g Y29uc3Q6IHBpcGVsaW5lCj4gKwo+ICsgICMgRGVsYXkgZGVmaW5pdGlvbnMgZm9yIE1lc29uOGIg YW5kIG5ld2VyIChpbmNsdWRpbmcgVDcpCj4gKyAgLSBpZjoKPiArICAgICAgcHJvcGVydGllczoK PiArICAgICAgICBjb21wYXRpYmxlOgo+ICsgICAgICAgICAgY29udGFpbnM6Cj4gKyAgICAgICAg ICAgIGVudW06Cj4gKyAgICAgICAgICAgICAgLSBhbWxvZ2ljLG1lc29uOGItZHdtYWMKPiArICAg ICAgICAgICAgICAtIGFtbG9naWMsbWVzb244bTItZHdtYWMKPiArICAgICAgICAgICAgICAtIGFt bG9naWMsbWVzb24tZ3hiYi1kd21hYwo+ICsgICAgICAgICAgICAgIC0gYW1sb2dpYyxtZXNvbi1h eGctZHdtYWMKPiArICAgICAgICAgICAgICAtIGFtbG9naWMsbWVzb24tZzEyYS1kd21hYwo+ICsg ICAgICAgICAgICAgIC0gYW1sb2dpYyx0Ny1kd21hYwo+ICsgICAgdGhlbjoKPiArICAgICAgcHJv cGVydGllczoKPiAgICAgICAgICBhbWxvZ2ljLHR4LWRlbGF5LW5zOgo+ICAgICAgICAgICAgZW51 bTogWzAsIDIsIDQsIDZdCj4gICAgICAgICAgICBkZWZhdWx0OiAyCgpbU2V2ZXJpdHk6IE1lZGl1 bV0KRG9lcyB0aGUgc2NoZW1hIGxhY2sgY29uc3RyYWludHMgZm9yIHR4LWludGVybmFsLWRlbGF5 LXBzPwoKVGhlIGRyaXZlciByZWFkcyB0eC1pbnRlcm5hbC1kZWxheS1wcyBmcm9tIHRoZSBkZXZp Y2UgdHJlZSBhbmQgYXNzaWducyBpdAp3aXRob3V0IGFueSBib3VuZHMgY2hlY2tpbmc6Cgpkcml2 ZXJzL25ldC9ldGhlcm5ldC9zdG1pY3JvL3N0bW1hYy9kd21hYy1tZXNvbjhiLmM6bWVzb244Yl9k d21hY19wcm9iZSgpIHsKICAgIC4uLgoJaWYgKCFvZl9wcm9wZXJ0eV9yZWFkX3UzMihwZGV2LT5k ZXYub2Zfbm9kZSwgInR4LWludGVybmFsLWRlbGF5LXBzIiwKCQkJCSAgJnR4X2RlbGF5X3BzKSkK CQlkd21hYy0+dHhfZGVsYXlfbnMgPSB0eF9kZWxheV9wcyAvIDEwMDA7CiAgICAuLi4KfQoKQmVj YXVzZSBpdCBpcyBub3QgdmFsaWRhdGVkLCBhIHZhbHVlID49IDgwMDAgKDhucykgd2lsbCBiZSBz aWxlbnRseSB0cnVuY2F0ZWQKYnkgdGhlIDItYml0IFBSR19FVEgwX1RYRExZX01BU0s6Cgpkcml2 ZXJzL25ldC9ldGhlcm5ldC9zdG1pY3JvL3N0bW1hYy9kd21hYy1tZXNvbjhiLmM6bWVzb244Yl9p bml0X3JnbWlpX2RlbGF5cygpIHsKICAgIC4uLgoJdHhfZGx5X2NvbmZpZyA9IEZJRUxEX1BSRVAo UFJHX0VUSDBfVFhETFlfTUFTSywKCQkJCSAgIGR3bWFjLT50eF9kZWxheV9ucyA+PiAxKTsKICAg IC4uLgp9CgpCZWNhdXNlIHRoZSBzY2hlbWEgZG9lcyBub3QgZGVmaW5lIGNvbnN0cmFpbnRzIGZv ciB0eC1pbnRlcm5hbC1kZWxheS1wcwphbmQgdGhlIGRyaXZlciBkb2VzIG5vdCB2YWxpZGF0ZSB0 aGUgYm91bmRzLCBhIG1pc2NvbmZpZ3VyZWQgRFRTIHdpbGwgc2lsZW50bHkKZmFpbCBhbmQgbWlz Y29uZmlndXJlIHRoZSBoYXJkd2FyZS4KCi0tIApTYXNoaWtvIEFJIHJldmlldyDCtyBodHRwczov L3Nhc2hpa28uZGV2LyMvcGF0Y2hzZXQvMjAyNjEwMDcwODI2MjcuNjM4MDctMS10YW51cmVAbGlu dXguY29tP3BhcnQ9MwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KbGludXgtYW1sb2dpYyBtYWlsaW5nIGxpc3QKbGludXgtYW1sb2dpY0BsaXN0cy5pbmZy YWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGlu dXgtYW1sb2dpYwo=