From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B06F741D4E9 for ; Thu, 8 Oct 2026 08:26:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791448018; cv=none; b=kUo8BKeXZ2xVyqRCYmwnOdKPn/l9t5SS60XUYVkYiq1tmTgLJF1DyTT2JLHPEcbBNQYAToMW+xfOCR4qYpyHrhWQVV8VM6Lgp89Gfo0uik4LAtQl1ay+xs4+Sds93ChtNVVQremFj26NzL2xea7SLiC5PHeZsoqYI3yAHVIns3g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791448018; c=relaxed/simple; bh=mTvg6KcNWngMK9UYnZj2cCjCP/WJFUTI3inxM+yZ1es=; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type: Date; b=RwRR2jMlQ9oSknheSQm2dRnJkqcY+WQ5DKd/DzZuiHxdVW2pKow1K1WEFmUQEQsJ85u3cRZQwU8eQYCZFJTWWfZ7XGPIA0fb02qC5jpnKzXG4wMij7Zb62E6ideIj0nmADnFn/Pc9/+mwHdfk592MTJdx2VTUE67BT7I4TS4iio= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FGT1UxWL; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FGT1UxWL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1F6971F00893; Thu, 8 Oct 2026 08:26:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791448017; bh=1CAsfYXouPqaPw4SppP8YN6Wq5UXbGRuoARLoWBg7oc=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=FGT1UxWLPTie1j3ovS8QLZAZ8ZuoYPfd3fSxcOP+R9PpZhoqB9FWtqDdPY6+y1Vm/ PQ3mDM6Dm7rRAbheBij+U7K/b7HZOfrFs2xRWnVuOpLYaO80AJWCmK1c7lwJHUAa1n Ke964HOC5WCgweWaRj1uSqmrrLnWpa6kZySif66hNEkiHWxkMb2auNr8gKxqFi6TWZ wTeqKXL5PuOZu64PzGFuLQfkSOHayFlWPBR3mDhL3DhRhJAmeb2QFjOm9j/ZqYzldV wrl3AgPIsDFeyQ1plPXPwGLd5B41yP9mZoHxLzwzE3AFZBct3K82pof+SzlQIfxmVA +BRyT2VF5bV9w== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [RFC PATCH v2 7/7] arm64: dts: amlogic: t7: khadas-vim4: enable the ethernet port Reply-To: sashiko-reviews@lists.linux.dev To: "Lucas Tanure" Cc: devicetree@vger.kernel.org, neil.armstrong@linaro.org, robh@kernel.org, linux-amlogic@lists.infradead.org, conor+dt@kernel.org In-Reply-To: <20261007082627.63807-8-tanure@linux.com> References: <20261007082627.63807-1-tanure@linux.com> <20261007082627.63807-8-tanure@linux.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Thu, 08 Oct 2026 08:26:56 +0000 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Low] dts: magic number used for GPIOH_6 interrupt instead of macro -- commit f585da8dc95da5050c5f6a8bd4b1962e662ae547 Author: Lucas Tanure arm64: dts: amlogic: t7: khadas-vim4: enable the ethernet port This commit enables the gigabit ethernet controller on the Khadas VIM4 boar= d, configuring it to communicate with the external Realtek RTL8211F PHY over RGMII. It also configures the RGMII delays and sets up the PHY interrupt wiring. > diff --git a/arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-khadas-vim4.dt= s b/arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-khadas-vim4.dts > index 0fa83362b4179..4a2b0b5636559 100644 > --- a/arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-khadas-vim4.dts > +++ b/arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-khadas-vim4.dts [ ... ] > @@ -256,6 +257,27 @@ xtal: xtal-clk { > }; > }; [ ... ] > +&ext_mdio { > + external_phy: ethernet-phy@0 { > + /* Realtek RTL8211FD-CG */ > + reg =3D <0>; > + max-speed =3D <1000>; > + > + interrupt-parent =3D <&gpio_intc>; > + /* RGMII_INT on GPIOH_6 */ > + interrupts =3D <154 IRQ_TYPE_LEVEL_LOW>; [Severity: Low] Is there a reason to use the magic number 154 here instead of the predefined GPIOH_6 macro from dt-bindings/gpio/amlogic,t7-periphs-pinctrl.h? Using the macro directly might improve maintainability and readability. > + }; > +}; > + --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261007082627.6380= 7-1-tanure@linux.com?part=3D7 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 26CF9CA600E for ; Thu, 8 Oct 2026 08:27:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date:References: In-Reply-To:Cc:To:Subject:From:Message-ID:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XkDzPZlBfnlPJ3fuV0ThIrrSuMNgaBbWh9iaJr+esRE=; b=iR9nsxsHd53XP4 5hHbIwCdlQDPyS2G2M0Vn2Rj3gaemGYNJjfOGXtAykQUXJBkddN0NZPJwj/d6rQfFoy4sehJIX57P 6UgPUHB7uIZyj0AOZn5IGn5TNH89mS6xLE5y3PzQl/UbRWktHEiOE182OuAM04VPTzFeauKuKYvg6 W664g29SfU3ZD0+LT5jejU9qKeURTEIhUwBzR3DlsPYtw6E2+Xqucheqohvyd17qBMWBvi2Lf+DXe E5Nxy8O9KI/AhBMKDJYQbNmEHz2gIhRW5Y2H+M6+NoMzvFVZHHJq0EBkoSxWguogeRD+UV6kAgTk0 DyrPSS/0hGWUwY6INrUA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xEjSt-00000003rdw-1Ssh; Thu, 08 Oct 2026 08:26:59 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xEjSs-00000003rdi-0W9X for linux-amlogic@lists.infradead.org; Thu, 08 Oct 2026 08:26:58 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 896B8439B8; Thu, 8 Oct 2026 08:26:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1F6971F00893; Thu, 8 Oct 2026 08:26:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791448017; bh=1CAsfYXouPqaPw4SppP8YN6Wq5UXbGRuoARLoWBg7oc=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=FGT1UxWLPTie1j3ovS8QLZAZ8ZuoYPfd3fSxcOP+R9PpZhoqB9FWtqDdPY6+y1Vm/ PQ3mDM6Dm7rRAbheBij+U7K/b7HZOfrFs2xRWnVuOpLYaO80AJWCmK1c7lwJHUAa1n Ke964HOC5WCgweWaRj1uSqmrrLnWpa6kZySif66hNEkiHWxkMb2auNr8gKxqFi6TWZ wTeqKXL5PuOZu64PzGFuLQfkSOHayFlWPBR3mDhL3DhRhJAmeb2QFjOm9j/ZqYzldV wrl3AgPIsDFeyQ1plPXPwGLd5B41yP9mZoHxLzwzE3AFZBct3K82pof+SzlQIfxmVA +BRyT2VF5bV9w== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [RFC PATCH v2 7/7] arm64: dts: amlogic: t7: khadas-vim4: enable the ethernet port To: "Lucas Tanure" Cc: devicetree@vger.kernel.org, neil.armstrong@linaro.org, robh@kernel.org, linux-amlogic@lists.infradead.org, conor+dt@kernel.org In-Reply-To: <20261007082627.63807-8-tanure@linux.com> References: <20261007082627.63807-1-tanure@linux.com> <20261007082627.63807-8-tanure@linux.com> Date: Thu, 08 Oct 2026 08:26:56 +0000 X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW0xvd10gZHRzOiBtYWdpYyBudW1i ZXIgdXNlZCBmb3IgR1BJT0hfNiBpbnRlcnJ1cHQgaW5zdGVhZCBvZiBtYWNybwotLQoKY29tbWl0 IGY1ODVkYThkYzk1ZGE1MDUwYzVmNmE4YmQ0YjE5NjJlNjYyYWU1NDcKQXV0aG9yOiBMdWNhcyBU YW51cmUgPHRhbnVyZUBsaW51eC5jb20+Cgphcm02NDogZHRzOiBhbWxvZ2ljOiB0Nzoga2hhZGFz LXZpbTQ6IGVuYWJsZSB0aGUgZXRoZXJuZXQgcG9ydAoKVGhpcyBjb21taXQgZW5hYmxlcyB0aGUg Z2lnYWJpdCBldGhlcm5ldCBjb250cm9sbGVyIG9uIHRoZSBLaGFkYXMgVklNNCBib2FyZCwKY29u ZmlndXJpbmcgaXQgdG8gY29tbXVuaWNhdGUgd2l0aCB0aGUgZXh0ZXJuYWwgUmVhbHRlayBSVEw4 MjExRiBQSFkgb3ZlcgpSR01JSS4gSXQgYWxzbyBjb25maWd1cmVzIHRoZSBSR01JSSBkZWxheXMg YW5kIHNldHMgdXAgdGhlIFBIWSBpbnRlcnJ1cHQKd2lyaW5nLgoKPiBkaWZmIC0tZ2l0IGEvYXJj aC9hcm02NC9ib290L2R0cy9hbWxvZ2ljL2FtbG9naWMtdDctYTMxMWQyLWtoYWRhcy12aW00LmR0 cyBiL2FyY2gvYXJtNjQvYm9vdC9kdHMvYW1sb2dpYy9hbWxvZ2ljLXQ3LWEzMTFkMi1raGFkYXMt dmltNC5kdHMKPiBpbmRleCAwZmE4MzM2MmI0MTc5Li40YTJiMGI1NjM2NTU5IDEwMDY0NAo+IC0t LSBhL2FyY2gvYXJtNjQvYm9vdC9kdHMvYW1sb2dpYy9hbWxvZ2ljLXQ3LWEzMTFkMi1raGFkYXMt dmltNC5kdHMKPiArKysgYi9hcmNoL2FybTY0L2Jvb3QvZHRzL2FtbG9naWMvYW1sb2dpYy10Ny1h MzExZDIta2hhZGFzLXZpbTQuZHRzCgpbIC4uLiBdCgo+IEBAIC0yNTYsNiArMjU3LDI3IEBAIHh0 YWw6IHh0YWwtY2xrIHsKPiAgCX07Cj4gIH07CgpbIC4uLiBdCgo+ICsmZXh0X21kaW8gewo+ICsJ ZXh0ZXJuYWxfcGh5OiBldGhlcm5ldC1waHlAMCB7Cj4gKwkJLyogUmVhbHRlayBSVEw4MjExRkQt Q0cgKi8KPiArCQlyZWcgPSA8MD47Cj4gKwkJbWF4LXNwZWVkID0gPDEwMDA+Owo+ICsKPiArCQlp bnRlcnJ1cHQtcGFyZW50ID0gPCZncGlvX2ludGM+Owo+ICsJCS8qIFJHTUlJX0lOVCBvbiBHUElP SF82ICovCj4gKwkJaW50ZXJydXB0cyA9IDwxNTQgSVJRX1RZUEVfTEVWRUxfTE9XPjsKCltTZXZl cml0eTogTG93XQpJcyB0aGVyZSBhIHJlYXNvbiB0byB1c2UgdGhlIG1hZ2ljIG51bWJlciAxNTQg aGVyZSBpbnN0ZWFkIG9mIHRoZSBwcmVkZWZpbmVkCkdQSU9IXzYgbWFjcm8gZnJvbSBkdC1iaW5k aW5ncy9ncGlvL2FtbG9naWMsdDctcGVyaXBocy1waW5jdHJsLmg/IFVzaW5nIHRoZQptYWNybyBk aXJlY3RseSBtaWdodCBpbXByb3ZlIG1haW50YWluYWJpbGl0eSBhbmQgcmVhZGFiaWxpdHkuCgo+ ICsJfTsKPiArfTsKPiArCgotLSAKU2FzaGlrbyBBSSByZXZpZXcgwrcgaHR0cHM6Ly9zYXNoaWtv LmRldi8jL3BhdGNoc2V0LzIwMjYxMDA3MDgyNjI3LjYzODA3LTEtdGFudXJlQGxpbnV4LmNvbT9w YXJ0PTcKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxp bnV4LWFtbG9naWMgbWFpbGluZyBsaXN0CmxpbnV4LWFtbG9naWNAbGlzdHMuaW5mcmFkZWFkLm9y ZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFtbG9n aWMK