From: sashiko-bot@kernel.org
To: "Shawn Lin" <shawn.lin@rock-chips.com>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI/pwrctrl: Only destroy devices created by pwrctrl core
Date: Thu, 08 Oct 2026 08:28:58 +0000 [thread overview]
Message-ID: <sashiko-outbox-163840@kernel.org> (raw)
In-Reply-To: <1791446700-100166-1-git-send-email-shawn.lin@rock-chips.com>
> pci_pwrctrl_create_device() only creates platform devices for OF nodes
> that pci_pwrctrl_is_required() accepts, but pci_pwrctrl_destroy_device()
> unregisters the platform device of every available child node without
> that check.
>
> Nodes under a PCI host controller that are not pwrctrl devices may have
> been populated by another mechanism. Destroying them here would tear
> down devices owned by other code.
>
> Mirror the check done at creation time so that only devices created by
> the pwrctrl core are removed.
>
> Fixes: 4c4132489201 ("PCI/pwrctrl: Add APIs to create, destroy pwrctrl devices")
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/1791446700-100166-1-git-send-email-shawn.lin@rock-chips.com?part=1
next prev parent reply other threads:[~2026-10-08 8:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-08 8:05 [PATCH] PCI/pwrctrl: Only destroy devices created by pwrctrl core Shawn Lin
2026-10-08 8:28 ` sashiko-bot [this message]
2026-10-08 9:38 ` Bartosz Golaszewski
2026-10-08 23:32 ` Bjorn Helgaas
2026-10-09 0:24 ` Shawn Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-163840@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=shawn.lin@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.