Re: [PATCH v4 2/8] irqchip/al-fic: use %pOF and raise init log level

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] irqchip/al-fic: format string mismatch for PTR_ERR() error code
--

commit 8125021c81e1add1a1eecad3b85a1e6e742d6f48
Author: Eliav Farber <farbere@amazon.com>

irqchip/al-fic: use %pOF and raise init log level

This commit updates the driver's log messages to use %pOF, identifying FIC
instances by their full devicetree paths rather than bare node names. It also
fixes a grammar typo and raises the successful-initialization message log
level from debug to info.

> diff --git a/drivers/irqchip/irq-al-fic.c b/drivers/irqchip/irq-al-fic.c
> index 35581332b40e0..760bd08dcff4d 100644
> --- a/drivers/irqchip/irq-al-fic.c
> +++ b/drivers/irqchip/irq-al-fic.c

[ ... ]

> @@ -258,9 +257,8 @@ static int __init al_fic_init_dt(struct device_node *node,
>  			       node->name,
>  			       parent_irq);
>  	if (IS_ERR(fic)) {
> -		pr_err("%s: fail to initialize irqchip (%lu)\n",
> -		       node->name,
> -		       PTR_ERR(fic));
> +		pr_err("%pOF: fail to initialize irqchip (%lu)\n",
> +		       node, PTR_ERR(fic));

[Severity: Low]
Does this leave a format string mismatch for the PTR_ERR() return value?

Since PTR_ERR() returns a signed long error code, using the unsigned %lu format
specifier causes negative error codes to underflow and be displayed as massive
positive numbers (e.g., 18446744073709551594).

Would it be better to use %pe or %ld here so that the actual error value
remains legible if al_fic_wire_init() fails?

>  		ret = PTR_ERR(fic);
>  		goto err_irq_dispose;
>  	}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261008090058.38591-1-farbere@amazon.com?part=2