Re: [PATCH v6 02/11] arm64: dts: qcom: ipq5210: Introduce RDP504 common DT file

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] arm64: dts: qcom: undocumented SoC-wide thermal limit reduction
--

commit 0651d4639f9454796e2f9ce2439efba04746c6c9
Author: Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com>

arm64: dts: qcom: ipq5210: Introduce RDP504 common DT file

This commit refactors the RDP504 board configuration to extract common settings
into a new shared file. It enables board-specific peripherals like USB, PCIe,
and SPI NAND.

> diff --git a/arch/arm64/boot/dts/qcom/ipq5210.dtsi b/arch/arm64/boot/dts/qcom/ipq5210.dtsi
> index 161b5bb5a7f74..3183182d1cc71 100644
> --- a/arch/arm64/boot/dts/qcom/ipq5210.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq5210.dtsi
> @@ -823,7 +823,7 @@ ethphy-thermal {
>  
>  			trips {
>  				ethphy-critical {
> -					temperature = <125000>;
> +					temperature = <120000>;

[Severity: Medium]
The commit message solely describes extracting common board configurations for
the RDP504 board and enabling board-specific peripherals.

Is it intentional that this modifies the base SoC device tree file to lower the
critical temperature trip point for ethphy-thermal?

This alters the thermal characteristics for all IPQ5210-based boards. Should
this undocumented SoC-wide thermal limit reduction be separated into its own
commit to avoid unexpected regressions on other boards?

[ ... ]

> @@ -859,13 +859,13 @@ cpu0-thermal {
>  
>  			trips {
>  				cpu-critical {
> -					temperature = <120000>;
> +					temperature = <115000>;

[Severity: Medium]
Does this intentionally lower the critical temperature for cpu0-thermal in
ipq5210.dtsi?

This impacts performance throttling and shutdown limits for all boards using
this SoC, rather than just the RDP504 board described in the commit message.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261008-08-dts-v6-0-f9c4ec8664d8@oss.qualcomm.com?part=2