Re: [PATCH ath-next 16/17] wifi: ath12k: Resolve userPD ID per device

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] style: inefficient NULL check inside resource loop
--

commit 1ba3501c64845782d9fd054ea266b2485861b530
Author: Aaradhana Sahu <aaradhana.sahu@oss.qualcomm.com>

wifi: ath12k: Resolve userPD ID per device

This commit resolves the userPD ID based on the device address rather than
hardcoding it during AHB probe, which is necessary for multi-PD platforms.
It also sets multi-PD support based on the AHB device descriptor.

> diff --git a/drivers/net/wireless/ath/ath12k/wifi7/ahb.c b/drivers/net/wireless/ath/ath12k/wifi7/ahb.c
> index bff48b2fe124d..86359ed1eeb2b 100644
> --- a/drivers/net/wireless/ath/ath12k/wifi7/ahb.c
> +++ b/drivers/net/wireless/ath/ath12k/wifi7/ahb.c

[ ... ]

> @@ -43,6 +47,26 @@ static const struct of_device_id ath12k_wifi7_ahb_of_match[] = {
>  
>  MODULE_DEVICE_TABLE(of, ath12k_wifi7_ahb_of_match);
>  
> +static u32 ath12k_wifi7_ahb_get_userpd_id(struct ath12k_base *ab)
> +{
> +	const struct ath12k_ahb_userpd_map *map;
> +	struct resource *res;
> +	size_t i;
> +
> +	res = platform_get_resource(ab->pdev, IORESOURCE_MEM, 0);
> +
> +	for (i = 0; i < ARRAY_SIZE(ath12k_wifi7_ahb_userpd_map); i++) {
> +		map = &ath12k_wifi7_ahb_userpd_map[i];
> +
> +		if (res) {

[Severity: Low]
This isn't a bug, but could the NULL check for res be moved outside the loop?

Since res is retrieved before the loop and does not change during the iteration
in ath12k_wifi7_ahb_get_userpd_id(), checking it on every pass is redundant.
Returning early if res is NULL might make this slightly cleaner.

> +			if (map->io_start == res->start)
> +				return map->upd_id;
> +		}
> +	}
> +
> +	return 0;
> +}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261008-mpp_bringup-v1-0-2c5797b5e4ac@oss.qualcomm.com?part=16