Re: [PATCH v2 2/2] s390/crypto: Handle cpacf_kma() return code

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Critical] crypto: s390: missing 'out' label causes build failure
- [Low] s390/crypto: build error due to missing 'out' label
--

commit 45b229c79189e8165da09c03b30411703a7bf4ae
Author: Harald Freudenberger <freude@linux.ibm.com>

s390/crypto: Handle cpacf_kma() return code

This commit updates gcm_aes_crypt() to check the return code of cpacf_kma()
and bail out with -EIO on any non-zero result.

> diff --git a/arch/s390/crypto/aes_s390.c b/arch/s390/crypto/aes_s390.c
> index 62edc66d54788..0e35cca359146 100644
> --- a/arch/s390/crypto/aes_s390.c
> +++ b/arch/s390/crypto/aes_s390.c
> @@ -889,10 +889,13 @@ static int gcm_aes_crypt(struct aead_request *req, unsigned int flags)
>  		if (aad_bytes > 0)
>  			memcpy(gw_out.ptr, gw_in.ptr, aad_bytes);
>  
> -		cpacf_kma(ctx->fc | flags, &param,
> -			  gw_out.ptr + aad_bytes,
> -			  gw_in.ptr + aad_bytes, pc_bytes,
> -			  gw_in.ptr, aad_bytes);
> +		if (cpacf_kma(ctx->fc | flags, &param,
> +			      gw_out.ptr + aad_bytes,
> +			      gw_in.ptr + aad_bytes, pc_bytes,
> +			      gw_in.ptr, aad_bytes)) {
> +			ret = -EIO;
> +			goto out;

[Severity: Critical]
Does this code fail to compile? There does not appear to be an out label
defined anywhere within gcm_aes_crypt().

> +		}
>  
>  		n = aad_bytes + pc_bytes;
>  		if (gcm_in_walk_done(&gw_in, n) != n)

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261008105242.20730-1-freude@linux.ibm.com?part=2