From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7E96DCA6007 for ; Thu, 8 Oct 2026 11:39:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date:References: In-Reply-To:Cc:To:Subject:From:Message-ID:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ziYGnn9a0VAKB4kTpiiYpnSQ3rkBM0/CKJNwdAnQG4Q=; b=cQZr6+9ownbzWN 3FlUD+ItcjEYV7cIb6qQTRCqpd2m/pYDaRsTl12ArDBPn9x3OEaOj9OASN67XaFlGyyTQlZlmmtRT OiBlBJAI3+BYNxXbEOyArbJybHHkzY/je0k02B2Ny7YcqlaBYs5VZHKdCcV4VgrHtVpFBBD7imXzr N93mCbZ/o62Plu8CqIt4T3F2E/4k1hbMGQUQHRIILvaZuHqIfnwKlB2ANVTK8dUmbv7YP2XiHX77W iQbWAMdOAvUvWrgTpKRHb6o3tyZJRsjlhpJ4JSLHhy8OChbcNGADI/vRP3HCzGKbNe19RSBKfPX5F DnQ7ROAtsMundh4l6Omw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xEmTL-00000004GTT-3a7U; Thu, 08 Oct 2026 11:39:39 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xEmTL-00000004GTE-0KZZ for linux-phy@lists.infradead.org; Thu, 08 Oct 2026 11:39:39 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 87106438A1; Thu, 8 Oct 2026 11:39:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F09E21F000FF; Thu, 8 Oct 2026 11:39:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791459578; bh=MEQ/WGt30g3uE836dXb/ot0HcFGDv/bs7yWpwc7rEow=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=HWD0ha+IegfdYhFmuy2rzUEqcaXQXf5QiBo0iEwLisVoLqlOKCnPbiBAK/Rzw8oT/ dNoZGg4IXe1NxUV4oCuwES1tL1D8MSQfaWJTT+DjKpYetAn6zp94LNnYmfekJx1u3d ZkNsq2ofestTRkMVsXdDo5W627xn8ZXkTGJYNOpec8e3T/E3X0RarggocaojA0fwkg eOGJ/6RaDXGxJQM+7sSGroZECyoZrF/TgNatNR81C1s8MhV9LX2N6qWO/3v3hJNQgY esITsreCOD8k4K19DIrZ79g1YyRJ100Cj3JFU5DRjX4aYVyT7DYc3xUqXCk/Q++lse AU6t7A1G7w3vg== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH 2/3] phy: aspeed: Add ASPEED PCIe PHY driver To: "Jacky Chou" Cc: linux-phy@lists.infradead.org, neil.armstrong@linaro.org, robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org, vkoul@kernel.org, olteanv@gmail.com In-Reply-To: <20261008-aspeed_pcie_phy-v1-2-96764937aef0@aspeedtech.com> References: <20261008-aspeed_pcie_phy-v1-0-96764937aef0@aspeedtech.com> <20261008-aspeed_pcie_phy-v1-2-96764937aef0@aspeedtech.com> Date: Thu, 08 Oct 2026 11:39:37 +0000 X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MiBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW01lZGl1bV0gcGh5OiBhc3BlZWQ6 IERlc3RydWN0aXZlIG92ZXJ3cml0ZSBvZiBQRUhSX0dMT0JBTCBhbmQgUEVIUl9NSVNDXzVDIHJl Z2lzdGVycwotIFtMb3ddIGJ1aWxkOiBtaXNzaW5nIDxsaW51eC9iaXRmaWVsZC5oPiBhbmQgPGxp bnV4L2lvLmg+IGNhdXNlcyBDT01QSUxFX1RFU1QgZmFpbHVyZXMKLS0KCmNvbW1pdCBkNmM2ODdh ZjA4ZjUyY2U4YzUxMDY4ODNhMGFkYTM3MzUyOGZlMWI4CkF1dGhvcjogSmFja3kgQ2hvdSA8amFj a3lfY2hvdUBhc3BlZWR0ZWNoLmNvbT4KCnBoeTogYXNwZWVkOiBBZGQgQVNQRUVEIFBDSWUgUEhZ IGRyaXZlcgoKVGhpcyBjb21taXQgaW50cm9kdWNlcyB0aGUgQXNwZWVkIFBDSWUgUEhZIGNvbnRy b2xsZXIgZHJpdmVyIGZvcgpBU1QyNjAwLzI3MDAgcGxhdGZvcm1zLiBJdCBhZGRzIEtjb25maWcg YW5kIE1ha2VmaWxlIGNoYW5nZXMgYWxvbmdzaWRlCnRoZSBtYWluIGRyaXZlciBjb2RlIGltcGxl bWVudGluZyBQSFkgb3BlcmF0aW9ucy4KCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvcGh5L2FzcGVl ZC9waHktYXNwZWVkLXBjaWUuYyBiL2RyaXZlcnMvcGh5L2FzcGVlZC9waHktYXNwZWVkLXBjaWUu Ywo+IG5ldyBmaWxlIG1vZGUgMTAwNjQ0Cj4gaW5kZXggMDAwMDAwMDAwMDAwMC4uZWIzMDA4ODdi NjQ0MQo+IC0tLSAvZGV2L251bGwKPiArKysgYi9kcml2ZXJzL3BoeS9hc3BlZWQvcGh5LWFzcGVl ZC1wY2llLmMKPiBAQCAtMCwwICsxLDIzNyBAQAo+ICsvLyBTUERYLUxpY2Vuc2UtSWRlbnRpZmll cjogR1BMLTIuMCsKPiArLyoKPiArICogQ29weXJpZ2h0IDIwMjUgQXNwZWVkIFRlY2hub2xvZ3kg SW5jLgo+ICsgKi8KPiArCj4gKyNpbmNsdWRlIDxsaW51eC9jbGsuaD4KPiArI2luY2x1ZGUgPGxp bnV4L2Vyci5oPgo+ICsjaW5jbHVkZSA8bGludXgvbW9kdWxlLmg+Cj4gKyNpbmNsdWRlIDxsaW51 eC9wbGF0Zm9ybV9kZXZpY2UuaD4KPiArI2luY2x1ZGUgPGxpbnV4L3BoeS9wY2llLmg+Cj4gKyNp bmNsdWRlIDxsaW51eC9waHkvcGh5Lmg+CgpbU2V2ZXJpdHk6IExvd10KQ2FuIHRoaXMgY2F1c2Ug YnVpbGQgZmFpbHVyZXMgd2hlbiBDT01QSUxFX1RFU1QgaXMgZW5hYmxlZCBvbiBhcmNoaXRlY3R1 cmVzCnRoYXQgZG8gbm90IGltcGxpY2l0bHkgaW5jbHVkZSA8bGludXgvYml0ZmllbGQuaD4gYW5k IDxsaW51eC9pby5oPj8KClRoZSBGSUVMRF9QUkVQLCBGSUVMRF9NT0RJRlksIHJlYWRsLCBhbmQg d3JpdGVsIG1hY3JvcyBhbmQgZnVuY3Rpb25zIGFyZQp1c2VkIHRocm91Z2hvdXQgdGhpcyBmaWxl LCBidXQgdGhlaXIgaGVhZGVycyBhcmUgbm90IGV4cGxpY2l0bHkgaW5jbHVkZWQuCgpbIC4uLiBd Cj4gK3N0YXRpYyBpbnQgYXN0MjYwMF9waHlfc2V0X21vZGUoc3RydWN0IHBoeSAqcGh5LCBlbnVt IHBoeV9tb2RlIG1vZGUsCj4gKwkJCQlpbnQgc3VibW9kZSkKPiArewo+ICsJc3RydWN0IGFzcGVl ZF9wY2llX3BoeSAqcGNpZV9waHkgPSBwaHlfZ2V0X2RydmRhdGEocGh5KTsKPiArCj4gKwlzd2l0 Y2ggKHN1Ym1vZGUpIHsKPiArCWNhc2UgUEhZX01PREVfUENJRV9SQzoKPiArCQl3cml0ZWwoQVNU MjYwMF9QT1JUX1RZUEUoMHgzKSwgcGNpZV9waHktPnJlZyArIFBFSFJfR0xPQkFMKTsKCltTZXZl cml0eTogTWVkaXVtXQpDb3VsZCB0aGlzIHdyaXRlIHVuaW50ZW50aW9uYWxseSBjbGVhciBvdGhl ciBjb25maWd1cmF0aW9uIGJpdHMgaW4gUEVIUl9HTE9CQUw/Ckl0IG92ZXJ3cml0ZXMgdGhlIGVu dGlyZSByZWdpc3RlciBpbnN0ZWFkIG9mIHBlcmZvcm1pbmcgYSByZWFkLW1vZGlmeS13cml0ZQpv cGVyYXRpb24uCgo+ICsJCWJyZWFrOwo+ICsJZGVmYXVsdDoKPiArCQlkZXZfZXJyKCZwaHktPmRl diwgIlVuc3VwcG9ydGVkIHN1Ym1vZGUgJWRcbiIsIHN1Ym1vZGUpOwo+ICsJCXJldHVybiAtRUlO VkFMOwo+ICsJfQo+ICsKPiArCXJldHVybiAwOwo+ICt9CgpbIC4uLiBdCj4gK3N0YXRpYyBpbnQg YXN0MjcwMF9waHlfc2V0X21vZGUoc3RydWN0IHBoeSAqcGh5LCBlbnVtIHBoeV9tb2RlIG1vZGUs Cj4gKwkJCQlpbnQgc3VibW9kZSkKPiArewo+ICsJc3RydWN0IGFzcGVlZF9wY2llX3BoeSAqcGNp ZV9waHkgPSBwaHlfZ2V0X2RydmRhdGEocGh5KTsKPiArCXUzMiBjZmdfdmFsOwo+ICsKPiArCXN3 aXRjaCAoc3VibW9kZSkgewo+ICsJY2FzZSBQSFlfTU9ERV9QQ0lFX1JDOgo+ICsJCXdyaXRlbCgw LCBwY2llX3BoeS0+cmVnICsgUEVIUl9NSVNDXzI3OCk7Cj4gKwkJd3JpdGVsKFNFTF9JTlRFUk5B TF9SRVNFVCwgcGNpZV9waHktPnJlZyArIFBFSFJfTUlTQ18yODApOwo+ICsJCXdyaXRlbChQT1NU RURfREFUQV9DUkVESVRTKDB4YzApIHwgUE9TVEVEX0hFQURFUl9DUkVESVRTKDB4YSksCj4gKwkJ ICAgICAgIHBjaWVfcGh5LT5yZWcgKyBQRUhSX01JU0NfNzApOwo+ICsJCXdyaXRlbChDT01QTEVU SU9OX0RBVEFfQ1JFRElUUygweDMwKSB8IENPTVBMRVRJT05fSEVBREVSX0NSRURJVFMoMHg4KSwK PiArCQkgICAgICAgcGNpZV9waHktPnJlZyArIFBFSFJfTUlTQ183OCk7Cj4gKwkJd3JpdGVsKExP Q0FMX1NDQUxFX1NVUCwgcGNpZV9waHktPnJlZyArIFBFSFJfTUlTQ181OCk7Cj4gKwkJd3JpdGVs KENPTkZJR19SQ19ERVZJQ0UsIHBjaWVfcGh5LT5yZWcgKyBQRUhSX01JU0NfNUMpOwoKW1NldmVy aXR5OiBNZWRpdW1dCkRvZXMgd3JpdGluZyBDT05GSUdfUkNfREVWSUNFIGRpcmVjdGx5IHRvIFBF SFJfTUlTQ181QyByaXNrIHplcm9pbmcgb3V0IG90aGVyCmJpdHMgaW4gdGhpcyByZWdpc3Rlcj8K CkEgcmVhZC1tb2RpZnktd3JpdGUgcGF0dGVybiBtaWdodCBiZSBuZWVkZWQgaGVyZSwgc2ltaWxh ciB0byBob3cgUEVIUl9NSVNDXzYwCmlzIGhhbmRsZWQganVzdCBiZWxvdyB0aGlzLgoKPiArCQlj ZmdfdmFsID0gcmVhZGwocGNpZV9waHktPnJlZyArIFBFSFJfTUlTQ182MCk7Cj4gKwkJRklFTERf TU9ESUZZKEFTVDI3MDBfUE9SVF9UWVBFX01BU0ssICZjZmdfdmFsLAo+ICsJCQkgICAgIFBPUlRf VFlQRV9ST09UKTsKPiArCQl3cml0ZWwoY2ZnX3ZhbCwgcGNpZV9waHktPnJlZyArIFBFSFJfTUlT Q182MCk7CgotLSAKU2FzaGlrbyBBSSByZXZpZXcgwrcgaHR0cHM6Ly9zYXNoaWtvLmRldi8jL3Bh dGNoc2V0LzIwMjYxMDA4LWFzcGVlZF9wY2llX3BoeS12MS0wLTk2NzY0OTM3YWVmMEBhc3BlZWR0 ZWNoLmNvbT9wYXJ0PTIKCi0tIApsaW51eC1waHkgbWFpbGluZyBsaXN0CmxpbnV4LXBoeUBsaXN0 cy5pbmZyYWRlYWQub3JnCmh0dHBzOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2xpbnV4LXBoeQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8FE053ACEF9 for ; Thu, 8 Oct 2026 11:39:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791459579; cv=none; b=cSUsqjpQI2AEUcXInEm3T3T06bYVvbo5LVoM841U5V1y6Irgdf5PRy2nd/gTV4fINGbdQLhkHpb1E1syohDSHjL/kRHfRZhDyKvpeQGc5lTpt426DMopNmXd8WBEM9dKm4aArZkFBMGkkIwHZSNZt62FnDBFpoYYye7W0CLsDR4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791459579; c=relaxed/simple; bh=ZBS/b90L0keqYfOnhlmEu2C4o4EF6lGnq1y/3O5sTNM=; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type: Date; b=mcWocdXShCkp531nCwjLUv7PVF3HX+LVuHp+Pozg+s3AbgGqH6PytwalQFLizte6u0TkzayWMbjp9eGpUpf7ZVa4rK+IQ/FSG6Hk00LnfaqKOlK71aydnfQeEeiqNj6kCegnSJ6NiJ7I2E7zYY6SarNGCNiSA60xrlvUmiJ7ZBY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=HWD0ha+I; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="HWD0ha+I" Received: by smtp.kernel.org (Postfix) with ESMTPSA id F09E21F000FF; Thu, 8 Oct 2026 11:39:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791459578; bh=MEQ/WGt30g3uE836dXb/ot0HcFGDv/bs7yWpwc7rEow=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=HWD0ha+IegfdYhFmuy2rzUEqcaXQXf5QiBo0iEwLisVoLqlOKCnPbiBAK/Rzw8oT/ dNoZGg4IXe1NxUV4oCuwES1tL1D8MSQfaWJTT+DjKpYetAn6zp94LNnYmfekJx1u3d ZkNsq2ofestTRkMVsXdDo5W627xn8ZXkTGJYNOpec8e3T/E3X0RarggocaojA0fwkg eOGJ/6RaDXGxJQM+7sSGroZECyoZrF/TgNatNR81C1s8MhV9LX2N6qWO/3v3hJNQgY esITsreCOD8k4K19DIrZ79g1YyRJ100Cj3JFU5DRjX4aYVyT7DYc3xUqXCk/Q++lse AU6t7A1G7w3vg== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH 2/3] phy: aspeed: Add ASPEED PCIe PHY driver Reply-To: sashiko-reviews@lists.linux.dev To: "Jacky Chou" Cc: linux-phy@lists.infradead.org, neil.armstrong@linaro.org, robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org, vkoul@kernel.org, olteanv@gmail.com In-Reply-To: <20261008-aspeed_pcie_phy-v1-2-96764937aef0@aspeedtech.com> References: <20261008-aspeed_pcie_phy-v1-0-96764937aef0@aspeedtech.com> <20261008-aspeed_pcie_phy-v1-2-96764937aef0@aspeedtech.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Thu, 08 Oct 2026 11:39:37 +0000 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 2 potential issue(= s) to consider: - [Medium] phy: aspeed: Destructive overwrite of PEHR_GLOBAL and PEHR_MISC_= 5C registers - [Low] build: missing and causes COMPILE_T= EST failures -- commit d6c687af08f52ce8c5106883a0ada373528fe1b8 Author: Jacky Chou phy: aspeed: Add ASPEED PCIe PHY driver This commit introduces the Aspeed PCIe PHY controller driver for AST2600/2700 platforms. It adds Kconfig and Makefile changes alongside the main driver code implementing PHY operations. > diff --git a/drivers/phy/aspeed/phy-aspeed-pcie.c b/drivers/phy/aspeed/ph= y-aspeed-pcie.c > new file mode 100644 > index 0000000000000..eb300887b6441 > --- /dev/null > +++ b/drivers/phy/aspeed/phy-aspeed-pcie.c > @@ -0,0 +1,237 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/* > + * Copyright 2025 Aspeed Technology Inc. > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include [Severity: Low] Can this cause build failures when COMPILE_TEST is enabled on architectures that do not implicitly include and ? The FIELD_PREP, FIELD_MODIFY, readl, and writel macros and functions are used throughout this file, but their headers are not explicitly included. [ ... ] > +static int ast2600_phy_set_mode(struct phy *phy, enum phy_mode mode, > + int submode) > +{ > + struct aspeed_pcie_phy *pcie_phy =3D phy_get_drvdata(phy); > + > + switch (submode) { > + case PHY_MODE_PCIE_RC: > + writel(AST2600_PORT_TYPE(0x3), pcie_phy->reg + PEHR_GLOBAL); [Severity: Medium] Could this write unintentionally clear other configuration bits in PEHR_GLO= BAL? It overwrites the entire register instead of performing a read-modify-write operation. > + break; > + default: > + dev_err(&phy->dev, "Unsupported submode %d\n", submode); > + return -EINVAL; > + } > + > + return 0; > +} [ ... ] > +static int ast2700_phy_set_mode(struct phy *phy, enum phy_mode mode, > + int submode) > +{ > + struct aspeed_pcie_phy *pcie_phy =3D phy_get_drvdata(phy); > + u32 cfg_val; > + > + switch (submode) { > + case PHY_MODE_PCIE_RC: > + writel(0, pcie_phy->reg + PEHR_MISC_278); > + writel(SEL_INTERNAL_RESET, pcie_phy->reg + PEHR_MISC_280); > + writel(POSTED_DATA_CREDITS(0xc0) | POSTED_HEADER_CREDITS(0xa), > + pcie_phy->reg + PEHR_MISC_70); > + writel(COMPLETION_DATA_CREDITS(0x30) | COMPLETION_HEADER_CREDITS(0x8), > + pcie_phy->reg + PEHR_MISC_78); > + writel(LOCAL_SCALE_SUP, pcie_phy->reg + PEHR_MISC_58); > + writel(CONFIG_RC_DEVICE, pcie_phy->reg + PEHR_MISC_5C); [Severity: Medium] Does writing CONFIG_RC_DEVICE directly to PEHR_MISC_5C risk zeroing out oth= er bits in this register? A read-modify-write pattern might be needed here, similar to how PEHR_MISC_= 60 is handled just below this. > + cfg_val =3D readl(pcie_phy->reg + PEHR_MISC_60); > + FIELD_MODIFY(AST2700_PORT_TYPE_MASK, &cfg_val, > + PORT_TYPE_ROOT); > + writel(cfg_val, pcie_phy->reg + PEHR_MISC_60); --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261008-aspeed_pci= e_phy-v1-0-96764937aef0@aspeedtech.com?part=3D2