From: sashiko-bot@kernel.org
To: "Changhuang Liang" <changhuang.liang@starfivetech.com>
Cc: linux-hwmon@vger.kernel.org, robh@kernel.org,
conor+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 6/6] hwmon: (peci/dimmtemp) Add support for Granite Rapids (GNR)
Date: Thu, 08 Oct 2026 11:48:53 +0000 [thread overview]
Message-ID: <sashiko-outbox-164104@kernel.org> (raw)
In-Reply-To: <20261008100623.7085-7-changhuang.liang@starfivetech.com>
> Add support for Granite Rapids (GNR) platform in PECI DIMM temperature
> monitoring driver.
>
> The GNR platform has different DIMM topology from previous generations,
> with 12 channel ranks (CHAN_RANK_MAX_ON_GNR) and 2 DIMM indexes per
> channel. Define these new constants and update CHAN_RANK_MAX to use
> the GNR value since it represents the maximum across all supported
> platforms.
>
> Since the current peci core does not support domains, accessing GNR's
> DIMM_TEMP_MAX and DIMM_TEMP_CRIT via PECI commands will be rejected
> and return completion code 0x90 (invalid request). To handle this, the
> read_thresholds callback is not defined for GNR, and the visibility
> logic is updated to skip exposing the max and crit temperature
> attributes.
>
> The minimum PECI revision required for GNR is 0x42.
>
> Signed-off-by: Changhuang Liang <changhuang.liang@starfivetech.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261008100623.7085-1-changhuang.liang@starfivetech.com?part=6
prev parent reply other threads:[~2026-10-08 11:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-08 10:06 [PATCH v3 0/6] Add StarFive JHB100 PECI support Changhuang Liang
2026-10-08 10:06 ` [PATCH v3 1/6] dt-bindings: peci: Add StarFive JHB100 PECI controller Changhuang Liang
2026-10-08 11:45 ` sashiko-bot
2026-10-08 10:06 ` [PATCH v3 2/6] peci: controller: Add StarFive JHB100 PECI driver Changhuang Liang
2026-10-08 11:52 ` sashiko-bot
2026-10-08 10:06 ` [PATCH v3 3/6] peci: Add support for PECI CC 0x83 retry condition Changhuang Liang
2026-10-08 11:51 ` sashiko-bot
2026-10-08 10:06 ` [PATCH v3 4/6] peci: cpu: Add Intel Granite Rapids support Changhuang Liang
2026-10-08 11:49 ` sashiko-bot
2026-10-08 10:06 ` [PATCH v3 5/6] hwmon: (peci/cputemp) Add support for Granite Rapids (GNR) Changhuang Liang
2026-10-08 11:48 ` sashiko-bot
2026-10-08 10:06 ` [PATCH v3 6/6] hwmon: (peci/dimmtemp) " Changhuang Liang
2026-10-08 11:48 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-164104@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=changhuang.liang@starfivetech.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.