From: sashiko-bot@kernel.org
To: dmatlack@google.com, "Tarun Sahu" <tarunsahu@google.com>,
"Pratyush Yadav" <pratyush@kernel.org>,
"Mike Rapoport" <rppt@kernel.org>,
"Pasha Tatashin" <pasha.tatashin@soleen.com>,
"Andrew Morton" <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, kexec@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/2] memblock: drop for_each_memblock_type() and open code its users
Date: Thu, 08 Oct 2026 19:12:39 +0000 [thread overview]
Message-ID: <sashiko-outbox-164503@kernel.org> (raw)
In-Reply-To: <20261008190828.3221718-1-tarunsahu@google.com>
> for_each_memblock_type() always starts the iteration at index 0 and its
> body is a trivial 'for' loop, so it hides very little. It also gets in
> the way of iterating from an arbitrary index, which the next patch
> needs.
>
> Remove the macro and open code its three users: memblock_add_range(),
> memblock_isolate_range() and memblock_dump(). While at it, move the
> region pointer into the loop body scope.
>
> No functional change.
>
> Reviewed-by: Pratyush Yadav <pratyush@kernel.org>
> Signed-off-by: Tarun Sahu <tarunsahu@google.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261008190828.3221718-1-tarunsahu@google.com?part=1
next prev parent reply other threads:[~2026-10-08 19:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-08 19:08 [PATCH v4 1/2] memblock: drop for_each_memblock_type() and open code its users Tarun Sahu
2026-10-08 19:08 ` [PATCH v4 2/2] memblock: use binary search to locate candidate regions Tarun Sahu
2026-10-08 19:14 ` sashiko-bot
2026-10-09 17:00 ` Mike Rapoport
2026-10-08 19:12 ` sashiko-bot [this message]
2026-10-13 10:06 ` [PATCH v4 1/2] memblock: drop for_each_memblock_type() and open code its users Mike Rapoport
2026-10-13 10:14 ` Mike Rapoport
2026-10-13 15:18 ` tarunsahu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-164503@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=dmatlack@google.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pasha.tatashin@soleen.com \
--cc=pratyush@kernel.org \
--cc=rppt@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=tarunsahu@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.