From: sashiko-bot@kernel.org
To: "Aleksei Berezin" <8967858b87@gmail.com>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: typec: ucsi: acpi: Add quirk for ASUS ROG Zephyrus Duo 16 GX650PI
Date: Thu, 08 Oct 2026 22:45:21 +0000 [thread overview]
Message-ID: <sashiko-outbox-164638@kernel.org> (raw)
In-Reply-To: <20261009-usb-next-v1-1-95a2288ad9b2@gmail.com>
> From: Aleksei Berezin <8967858b87@gmail.com>
>
> On the ASUS ROG Zephyrus Duo 16 (GX650PI, BIOS GX650PI.314) the firmware
> loads the EC-based variant of the AMD CPM UCSI SSDT ("CPMUCSI"). Its _DSM
> read function only copies MESSAGE_IN and CCI from the EC into the shared
> mailbox and never fills in the VERSION field. The only code that sets the
> version (M31F) lives in the "UCSIPLT" SSDT of the I2C-based variant, which
> is present in the firmware image but not loaded on this machine.
>
> As a result ucsi_register() reads a zero version and the probe fails
> silently with -ENODEV, so neither Type-C port is registered and no
> typec, usb_power_delivery or ucsi-source-psy devices are created.
>
> Reuse the existing zero-version workaround from the Acer Nitro ANV15-41
> quirk and assume UCSI 1.2 on this machine. With this change both ports,
> the PD partner and the UCSI power supplies are registered and report the
> connected USB PD charger correctly.
>
> Assisted-by: Claude Opus 5.5 iasl
> Signed-off-by: Aleksei Berezin <8967858b87@gmail.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261009-usb-next-v1-1-95a2288ad9b2@gmail.com?part=1
next prev parent reply other threads:[~2026-10-08 22:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-08 22:41 [PATCH] usb: typec: ucsi: acpi: Add quirk for ASUS ROG Zephyrus Duo 16 GX650PI Aleksei Berezin via B4 Relay
2026-10-08 22:41 ` Aleksei Berezin
2026-10-08 22:45 ` sashiko-bot [this message]
2026-10-09 11:44 ` Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-164638@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=8967858b87@gmail.com \
--cc=linux-usb@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.