From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 685DFCA5FED for ; Fri, 9 Oct 2026 03:35:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date:References: In-Reply-To:Cc:To:Subject:From:Message-ID:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+ZHTFX8TVDarI+St2hE9ojEGVey8H6AQ/huQ7OuGOT0=; b=GZffda+6rqcHU9 1mWms2gXcb7G2BwGYSP03JuRAsq8aPP5/EHn3MhponUgiHK0F1zDwqbtxTxfXR+5rKUmJYQwVND1F kndsVMymd+GKICQpZJwnQ6DK4M2u10NaKn5R0bopaTQYqyIBSrkchhihF7rbJuXt8NdLZUnhTRCX6 YdtdQlzXBq05hXvxzJidkilQtZqz8kv3SsxS+ffjPKcfShMGF9cgzYHIlvYqGJdJ0ec1MtLd3QsxY LzLfrPeg/OIger1GmJqR5x1poAC7uot9Te5ADQ9BL12Msd7ZI6D6lSK4xiyCmHQPCUa0Ywj1mIJoQ JehddTSSPOZmNW8Hg17w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xF1OW-00000005OjL-3raX; Fri, 09 Oct 2026 03:35:40 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xF1OV-00000005Oit-2qvL for linux-amlogic@lists.infradead.org; Fri, 09 Oct 2026 03:35:39 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id BD7A341AB3; Fri, 9 Oct 2026 03:35:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5B8521F000FF; Fri, 9 Oct 2026 03:35:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791516937; bh=vn9xLqecG/iJznrV55TfoGAVffj2F69FusTLuIK7Xls=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=V0X3Y28fW+NHoq3RweDwuh2RQ5ci7ttmF+8NvGWIsHuWWtRy7Kpz4wLs5AQ0eTGA1 QvzMAicJlOVtP7pw+XgWOiuHYkKLc9OFISe4qAuFIzuAH4z6MY+Jvl7AQoi+eMEunJ kqugpYApkOO4g8lTgOSGyECrmSsUWokow2TE1RzQ7qM6iZ9KG/v0tMCQWqf1FmXGKI G6KvqWM2YF2Rd0eeaFxt5oV6NIchiT1pxEIptWcLcQa2gGNdY2+0UILZwhZARpmPon AXPRHNs3wG8PdipIJgsOjSsjj0iKKDz3A2Ajt7B+DTIaSg0JVK/q5G9Yo8d70OVPRq ymBSzpvFZPj2Q== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 09/20] drm/msm/dp: Unwind resources when enabling a stream fails To: "Xilin Wu" Cc: linux-amlogic@lists.infradead.org, neil.armstrong@linaro.org, dri-devel@lists.freedesktop.org In-Reply-To: <20261009-msm-dp-hdr10-v2-9-1835d4966da3@radxa.com> References: <20261009-msm-dp-hdr10-v2-0-1835d4966da3@radxa.com> <20261009-msm-dp-hdr10-v2-9-1835d4966da3@radxa.com> Date: Fri, 09 Oct 2026 03:35:36 +0000 X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MiBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW0hpZ2hdIHBtOiBwbV9ydW50aW1l IHJlZmVyZW5jZSBsZWFrIGluIG1zbV9kcF9icmlkZ2VfZGV0ZWN0KCkKLSBbTWVkaXVtXSBkcm0v bXNtL2RwOiBkZWFkIGNvZGUgaW4gc3RyZWFtIGVuYWJsZSBhYm9ydCBwYXRoIGR1ZSB0byBzaW5r X2NvdW50IGludmFyaWFudAotLQoKY29tbWl0IGFlZWM3ZWI0YTU1Mjc2Mjk2NDAwMTFjYmE4OWQ3 YmJhYWY5MDM0MWMKQXV0aG9yOiBYaWxpbiBXdSA8c29waG9uQHJhZHhhLmNvbT4KU3ViamVjdDog ZHJtL21zbS9kcDogVW53aW5kIHJlc291cmNlcyB3aGVuIGVuYWJsaW5nIGEgc3RyZWFtIGZhaWxz CgpUaGlzIHBhdGNoIGludHJvZHVjZXMgcmVzb3VyY2UgdW53aW5kaW5nIGZvciBzdHJlYW0gZW5h YmxlIGZhaWx1cmVzIGJ5IHRyYWNraW5nCnRoZSBzdHJlYW0gUE0gcmVmZXJlbmNlIGFuZCBtYWlu bGluayBzdGFydHVwIHN0YXR1cy4gSXQgdW5pZmllcyB0aGUgcm9sbGJhY2sKcGF0aHMgYW5kIHBy b3BhZ2F0ZXMgZXJyb3JzIGZyb20gUEhZIGluaXRpYWxpemF0aW9uLgoKPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL21zbS9kcC9kcF9kaXNwbGF5LmMgYi9kcml2ZXJzL2dwdS9kcm0vbXNt L2RwL2RwX2Rpc3BsYXkuYwo+IGluZGV4IDc4N2VmYmNiNmMxMjQuLmIwNzZkNDRiNTExOGMgMTAw NjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL21zbS9kcC9kcF9kaXNwbGF5LmMKPiArKysgYi9k cml2ZXJzL2dwdS9kcm0vbXNtL2RwL2RwX2Rpc3BsYXkuYwo+IEBAIC05ODgsNiArMTAxNCw3IEBA IGVudW0gZHJtX2Nvbm5lY3Rvcl9zdGF0dXMgbXNtX2RwX2JyaWRnZV9kZXRlY3Qoc3RydWN0IGRy bV9icmlkZ2UgKmJyaWRnZSwKPiAgCj4gIAkJcHV0ID0gdHJ1ZTsKPiAgCX0KPiArdW5sb2NrOgo+ ICAJbXV0ZXhfdW5sb2NrKCZwcml2LT5wbHVnZ2VkX2xvY2spOwo+ICAKPiAgCWlmIChwdXQpCj4g IAkJcG1fcnVudGltZV9wdXRfc3luYygmZHAtPnBkZXYtPmRldik7CgpbU2V2ZXJpdHk6IEhpZ2hd CkRvZXMgbXNtX2RwX2JyaWRnZV9kZXRlY3QoKSBsZWFrIGEgUE0gcnVudGltZSByZWZlcmVuY2Ug aGVyZT8KCm1zbV9kcF9icmlkZ2VfZGV0ZWN0KCkgdW5jb25kaXRpb25hbGx5IGNhbGxzIHBtX3J1 bnRpbWVfcmVzdW1lX2FuZF9nZXQoKQplYXJsaWVyIGluIHRoZSBmdW5jdGlvbi4gSWYgdGhlIGRp c3BsYXkgaXMgYWxyZWFkeSBjb25uZWN0ZWQgKHByaXYtPnBsdWdnZWQKaXMgdHJ1ZSksIHRoZSBl eGl0IHBhdGggc2tpcHMgc2V0dGluZyBwdXQgPSB0cnVlLiAKCkFzIGEgcmVzdWx0LCBwbV9ydW50 aW1lX3B1dF9zeW5jKCkgaXMgbmV2ZXIgY2FsbGVkLCB3aGljaCBsZWFrcyB0aGUgUE0KcmVmZXJl bmNlLiBTaW5jZSB1c2Vyc3BhY2UgY2FuIHBvbGwgdGhlIGRldGVjdCBjYWxsYmFjayByZXBlYXRl ZGx5CihlLmcuLCB2aWEgRFJNX0lPQ1RMX01PREVfR0VUQ09OTkVDVE9SKSwgY291bGQgdGhpcyBs ZWFrIHRoZSBQTSByZWZlcmVuY2UKaW5kZWZpbml0ZWx5IGFuZCBwZXJtYW5lbnRseSBwcmV2ZW50 IHRoZSBkZXZpY2UgZnJvbSBzdXNwZW5kaW5nPwoKWyAuLi4gXQoKPiBAQCAtMTQ2MCw2ICsxNDkz LDUyIEBAIHZvaWQgbXNtX2RwX2Rpc3BsYXlfYXRvbWljX3ByZV9lbmFibGUoc3RydWN0IG1zbV9k cCAqbXNtX2RwX2Rpc3BsYXksCj4gIAltc21fZHBfZGlzcGxheV9zZXRfbW9kZShtc21fZHBfZGlz cGxheSwgJmNydGNfc3RhdGUtPmFkanVzdGVkX21vZGUsIGRwLT5wYW5lbCk7Cj4gIH0KPiAgCj4g K3N0YXRpYyB2b2lkIG1zbV9kcF9kaXNwbGF5X2Fib3J0X2VuYWJsZV9sb2NrZWQoc3RydWN0IG1z bV9kcF9kaXNwbGF5X3ByaXZhdGUgKmRwKQo+ICt7Cj4gKwlib29sIGtlZXBfYXV4Owo+ICsJaW50 IHJldDsKPiArCj4gKwlsb2NrZGVwX2Fzc2VydF9oZWxkKCZkcC0+cGx1Z2dlZF9sb2NrKTsKPiAr Cj4gKwlrZWVwX2F1eCA9ICFkcC0+bXNtX2RwX2Rpc3BsYXkuaXNfZWRwICYmIGRwLT5wbHVnZ2Vk ICYmCj4gKwkJbXNtX2RwX2F1eF9pc19saW5rX2Nvbm5lY3RlZChkcC0+YXV4KTsKPiArCj4gKwlp ZiAoZHAtPnN0cmVhbV9saW5rX2F0dGVtcHRlZCkgewo+ICsJCS8qIFRoZSBBVVggcGVlciBpcyB0 aGUgcmVtYWluaW5nIGRvbmdsZSwgbm90IGl0cyBhYnNlbnQgc2luay4gKi8KPiArCQlpZiAoa2Vl cF9hdXggJiYgIWRwLT5saW5rLT5zaW5rX2NvdW50ICYmIGRwLT5waHlfaW5pdGlhbGl6ZWQpCj4g KwkJCW1zbV9kcF9saW5rX3BzbV9jb25maWcoZHAtPmxpbmssICZkcC0+cGFuZWwtPmxpbmtfaW5m bywgdHJ1ZSk7CgpbU2V2ZXJpdHk6IE1lZGl1bV0KSXMgdGhpcyBQb3dlciBTYXZlIE1vZGUgKFBT TSkgY29uZmlndXJhdGlvbiBibG9jayB1bnJlYWNoYWJsZT8KClRoZSBjb25kaXRpb24gIWRwLT5s aW5rLT5zaW5rX2NvdW50IGlzIGV2YWx1YXRlZCBpbnNpZGUgdGhlCmlmIChkcC0+c3RyZWFtX2xp bmtfYXR0ZW1wdGVkKSBibG9jay4gSG93ZXZlciwgZHAtPnN0cmVhbV9saW5rX2F0dGVtcHRlZApp cyBvbmx5IHNldCB0byB0cnVlIGluIG1zbV9kcF9kaXNwbGF5X3ByZXBhcmVfbGlua19sb2NrZWQo KSBpZgpkcC0+bGluay0+c2lua19jb3VudCBpcyBub24temVyby4gCgpCZWNhdXNlIGJvdGggbXNt X2RwX2Rpc3BsYXlfcHJlcGFyZV9saW5rX2xvY2tlZCgpIGFuZCAKbXNtX2RwX2Rpc3BsYXlfYWJv cnRfZW5hYmxlX2xvY2tlZCgpIGV4ZWN1dGUgc2VxdWVudGlhbGx5IHdpdGhpbiB0aGUgc2FtZSAK cGx1Z2dlZF9sb2NrIGNyaXRpY2FsIHNlY3Rpb24gaW4gbXNtX2RwX2Rpc3BsYXlfYXRvbWljX2Vu YWJsZSgpLCBjb25jdXJyZW50CkhQRCBldmVudHMgY2Fubm90IG1vZGlmeSBzaW5rX2NvdW50LgoK RG9lc24ndCB0aGlzIG1lYW4gdGhlIGlubmVyIGNoZWNrICFkcC0+bGluay0+c2lua19jb3VudCB3 aWxsIGFsd2F5cyBldmFsdWF0ZQp0byBmYWxzZSwgcmVuZGVyaW5nIHRoaXMgZmFsbGJhY2sgZGVh ZCBjb2RlPwoKPiArCj4gKwkJbXNtX2RwX2N0cmxfb2ZmX3BpeGVsX2NsayhkcC0+Y3RybCk7Cj4g KwkJbXNtX2RwX2N0cmxfb2ZmX2xpbmsoZHAtPmN0cmwsIGRwLT5wYW5lbCk7Cj4gKwkJZHAtPnN0 cmVhbV9saW5rX2F0dGVtcHRlZCA9IGZhbHNlOwoKLS0gClNhc2hpa28gQUkgcmV2aWV3IMK3IGh0 dHBzOi8vc2FzaGlrby5kZXYvIy9wYXRjaHNldC8yMDI2MTAwOS1tc20tZHAtaGRyMTAtdjItMC0x ODM1ZDQ5NjZkYTNAcmFkeGEuY29tP3BhcnQ9OQoKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KbGludXgtYW1sb2dpYyBtYWlsaW5nIGxpc3QKbGludXgtYW1s b2dpY0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxt YW4vbGlzdGluZm8vbGludXgtYW1sb2dpYwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7EF73CA5FED for ; Fri, 9 Oct 2026 03:35:39 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BC66310FE48; Fri, 9 Oct 2026 03:35:38 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="V0X3Y28f"; dkim-atps=neutral Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id DA3DF10FE48 for ; Fri, 9 Oct 2026 03:35:37 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id BD7A341AB3; Fri, 9 Oct 2026 03:35:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5B8521F000FF; Fri, 9 Oct 2026 03:35:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791516937; bh=vn9xLqecG/iJznrV55TfoGAVffj2F69FusTLuIK7Xls=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=V0X3Y28fW+NHoq3RweDwuh2RQ5ci7ttmF+8NvGWIsHuWWtRy7Kpz4wLs5AQ0eTGA1 QvzMAicJlOVtP7pw+XgWOiuHYkKLc9OFISe4qAuFIzuAH4z6MY+Jvl7AQoi+eMEunJ kqugpYApkOO4g8lTgOSGyECrmSsUWokow2TE1RzQ7qM6iZ9KG/v0tMCQWqf1FmXGKI G6KvqWM2YF2Rd0eeaFxt5oV6NIchiT1pxEIptWcLcQa2gGNdY2+0UILZwhZARpmPon AXPRHNs3wG8PdipIJgsOjSsjj0iKKDz3A2Ajt7B+DTIaSg0JVK/q5G9Yo8d70OVPRq ymBSzpvFZPj2Q== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 09/20] drm/msm/dp: Unwind resources when enabling a stream fails To: "Xilin Wu" Cc: linux-amlogic@lists.infradead.org, neil.armstrong@linaro.org, dri-devel@lists.freedesktop.org In-Reply-To: <20261009-msm-dp-hdr10-v2-9-1835d4966da3@radxa.com> References: <20261009-msm-dp-hdr10-v2-0-1835d4966da3@radxa.com> <20261009-msm-dp-hdr10-v2-9-1835d4966da3@radxa.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 09 Oct 2026 03:35:36 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Thank you for your contribution! Sashiko AI review found 2 potential issue(= s) to consider: - [High] pm: pm_runtime reference leak in msm_dp_bridge_detect() - [Medium] drm/msm/dp: dead code in stream enable abort path due to sink_co= unt invariant -- commit aeec7eb4a5527629640011cba89d7bbaaf90341c Author: Xilin Wu Subject: drm/msm/dp: Unwind resources when enabling a stream fails This patch introduces resource unwinding for stream enable failures by trac= king the stream PM reference and mainlink startup status. It unifies the rollback paths and propagates errors from PHY initialization. > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp= /dp_display.c > index 787efbcb6c124..b076d44b5118c 100644 > --- a/drivers/gpu/drm/msm/dp/dp_display.c > +++ b/drivers/gpu/drm/msm/dp/dp_display.c > @@ -988,6 +1014,7 @@ enum drm_connector_status msm_dp_bridge_detect(struc= t drm_bridge *bridge, > =20 > put =3D true; > } > +unlock: > mutex_unlock(&priv->plugged_lock); > =20 > if (put) > pm_runtime_put_sync(&dp->pdev->dev); [Severity: High] Does msm_dp_bridge_detect() leak a PM runtime reference here? msm_dp_bridge_detect() unconditionally calls pm_runtime_resume_and_get() earlier in the function. If the display is already connected (priv->plugged is true), the exit path skips setting put =3D true.=20 As a result, pm_runtime_put_sync() is never called, which leaks the PM reference. Since userspace can poll the detect callback repeatedly (e.g., via DRM_IOCTL_MODE_GETCONNECTOR), could this leak the PM reference indefinitely and permanently prevent the device from suspending? [ ... ] > @@ -1460,6 +1493,52 @@ void msm_dp_display_atomic_pre_enable(struct msm_d= p *msm_dp_display, > msm_dp_display_set_mode(msm_dp_display, &crtc_state->adjusted_mode, dp-= >panel); > } > =20 > +static void msm_dp_display_abort_enable_locked(struct msm_dp_display_pri= vate *dp) > +{ > + bool keep_aux; > + int ret; > + > + lockdep_assert_held(&dp->plugged_lock); > + > + keep_aux =3D !dp->msm_dp_display.is_edp && dp->plugged && > + msm_dp_aux_is_link_connected(dp->aux); > + > + if (dp->stream_link_attempted) { > + /* The AUX peer is the remaining dongle, not its absent sink. */ > + if (keep_aux && !dp->link->sink_count && dp->phy_initialized) > + msm_dp_link_psm_config(dp->link, &dp->panel->link_info, true); [Severity: Medium] Is this Power Save Mode (PSM) configuration block unreachable? The condition !dp->link->sink_count is evaluated inside the if (dp->stream_link_attempted) block. However, dp->stream_link_attempted is only set to true in msm_dp_display_prepare_link_locked() if dp->link->sink_count is non-zero.=20 Because both msm_dp_display_prepare_link_locked() and=20 msm_dp_display_abort_enable_locked() execute sequentially within the same=20 plugged_lock critical section in msm_dp_display_atomic_enable(), concurrent HPD events cannot modify sink_count. Doesn't this mean the inner check !dp->link->sink_count will always evaluate to false, rendering this fallback dead code? > + > + msm_dp_ctrl_off_pixel_clk(dp->ctrl); > + msm_dp_ctrl_off_link(dp->ctrl, dp->panel); > + dp->stream_link_attempted =3D false; --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261009-msm-dp-hdr= 10-v2-0-1835d4966da3@radxa.com?part=3D9