From: sashiko-bot@kernel.org
To: "Hangbin Liu" <hangbin.liu@linux.dev>
Cc: mptcp@lists.linux.dev
Subject: Re: [PATCH mptcp-next] squash to "selftests: mptcp: convert iptables to nftables for mptcp_join.sh"
Date: Fri, 09 Oct 2026 07:31:13 +0000 [thread overview]
Message-ID: <sashiko-outbox-165003@kernel.org> (raw)
In-Reply-To: <20261009-mptcp_rm_debug-v1-1-a7b4fdbe1b5f@kylinos.cn>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] selftests: mptcp: incorrect squash target in commit message
--
commit 95308d8ced7d193c5aadb0348b4665a25a875b28
Author: Hangbin Liu <liuhangbin@kylinos.cn>
squash to "selftests: mptcp: convert iptables to nftables for mptcp_join.sh"
This commit removes the syn mark rule from the output filter in the mptcp
selftests. It is intended to be squashed into a previous patch converting
iptables to nftables.
> squash to "selftests: mptcp: convert iptables to nftables for mptcp_join.sh"
[Severity: Low]
Is the commit title targeting the correct script for this squash? The title
explicitly states "mptcp_join.sh", but the diff exclusively modifies
"mptcp_sockopt.sh".
If this is squashed into the "mptcp_join.sh" commit, it might cause confusion
about the patch's purpose or result in applying the squash to the wrong target
commit.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261009-mptcp_rm_debug-v1-1-a7b4fdbe1b5f@kylinos.cn?part=1
next prev parent reply other threads:[~2026-10-09 7:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-09 7:27 [PATCH mptcp-next] squash to "selftests: mptcp: convert iptables to nftables for mptcp_join.sh" Hangbin Liu
2026-10-09 7:31 ` sashiko-bot [this message]
2026-10-09 8:17 ` Hangbin Liu
2026-10-09 8:35 ` MPTCP CI
2026-10-09 9:49 ` [PATCH mptcp-next] squash to "selftests: mptcp: convert iptables to nftables for mptcp_sockopt.sh" Matthieu Baerts
-- strict thread matches above, loose matches on Subject: below --
2026-10-09 7:26 [PATCH mptcp-next] Squash to "selftests: mptcp: convert iptables to nftables for mptcp_join.sh" Hangbin Liu
2026-10-09 8:23 ` MPTCP CI
2026-10-09 9:03 ` Matthieu Baerts
2026-10-09 9:26 ` Hangbin Liu
2026-10-09 9:38 ` Matthieu Baerts
2026-10-09 9:48 ` Matthieu Baerts
2026-10-09 9:52 ` Matthieu Baerts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-165003@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=hangbin.liu@linux.dev \
--cc=mptcp@lists.linux.dev \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.