From: sashiko-bot@kernel.org
To: "Xilin Wu" <sophon@radxa.com>
Cc: linux-pci@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] PCI: of: Correct pci_set_of_node() return value documentation
Date: Fri, 09 Oct 2026 07:33:52 +0000 [thread overview]
Message-ID: <sashiko-outbox-165008@kernel.org> (raw)
In-Reply-To: <20261009-pci-of-disabled-bridges-v1-1-08708f9e1802@radxa.com>
> Commit 1a8c251cff20 ("PCI: move OF status = "disabled" detection to
> dev->match_driver") removed the availability check from pci_set_of_node().
> The function now returns 0 even when the device is disabled in the device
> tree, but its kernel-doc still says that it can return -ENODEV.
>
> Remove the stale -ENODEV description and use the kernel-doc Return:
> heading for the return value.
>
> Signed-off-by: Xilin Wu <sophon@radxa.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261009-pci-of-disabled-bridges-v1-0-08708f9e1802@radxa.com?part=1
next prev parent reply other threads:[~2026-10-09 7:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-09 7:25 [PATCH 0/2] PCI: of: Skip config reads for disabled bridges Xilin Wu
2026-10-09 7:25 ` [PATCH 1/2] PCI: of: Correct pci_set_of_node() return value documentation Xilin Wu
2026-10-09 7:33 ` sashiko-bot [this message]
2026-10-09 7:25 ` [PATCH 2/2] PCI: of: Avoid config reads for disabled bridge nodes Xilin Wu
2026-10-09 7:33 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-165008@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=sophon@radxa.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.