Re: [PATCH v5 1/2] dt-bindings: serial: Document WK2xxx SPI UART

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: missing constraints for wk2124/wk2132 flow-control and rs485
--

commit f014f512db212c81969cf531fd505916a62774fa
Author: Zi Jie Zhao <zjzhao@edatec.cn>

dt-bindings: serial: Document WK2xxx SPI UART

Add a DT binding for the WK2xxx SPI-to-UART bridge ICs (WK2124, WK2132,
WK2168, WK2212 and WK2204) from Chengdu Weikai Microelectronics (WKmic).

> diff --git a/Documentation/devicetree/bindings/serial/wkmic,wk2124.yaml b/Documentation/devicetree/bindings/serial/wkmic,wk2124.yaml
> new file mode 100644
> index 0000000000000..47a0cbdb5ca14
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/serial/wkmic,wk2124.yaml
> @@ -0,0 +1,119 @@
> [ ... ]
> +allOf:
> +  - $ref: /schemas/spi/spi-peripheral-props.yaml#
> +
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - wkmic,wk2132
> +              - wkmic,wk2212
> +    then:
> +      patternProperties:
> +        "^serial@[23]$": false

[Severity: Medium]
The commit message explicitly states: "Differentiate compatible strings by
channel count and register availability. WK2124 and WK2132 lack hardware
flow-control and RS-485 registers."

However, this conditional block only differentiates the models by channel
count. Since serial.yaml and rs485.yaml are referenced unconditionally for
all serial@[0-3] nodes, device trees that configure RS-485 or hardware flow
control on WK2124 and WK2132 will silently pass schema validation despite
the hardware lacking these registers.

Should there be an additional conditional block to reject RS-485 and hardware
flow-control properties for the WK2124 and WK2132 models?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261009082530.248219-1-zjzhao@edatec.cn?part=1