Re: [PATCH] arm64: dts: qcom: sm7225-fairphone-fp4: Add Sony IMX576 front camera support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 4 potential issue(s) to consider:
- [Low] dts: missing video-interface-devices.h header breaks build
- [Low] dts: undefined &camss label reference breaks build
- [Low] dts: missing reg property on unit-addressed port@3 node
- [Low] dts: undocumented compatible string sony,imx576
--

commit e48e7d28c163e33e1162a6d841602d728e3532e7
Author: Hardevsinh Palaniya <hardevsinh.palaniya@siliconsignals.io>

arm64: dts: qcom: sm7225-fairphone-fp4: Add Sony IMX576 front camera support

This commit adds device tree support for the Sony IMX576 front camera
sensor and connects it to CAMSS via CSIPHY3.

[ ... ]
> diff --git a/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts b/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts
> index 5d20ad93b0c54..b0c9b103cdc9c 100644
> --- a/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts
> +++ b/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts
> @@ -17,6 +17,8 @@
>  #include <dt-bindings/iio/qcom,spmi-adc7-pmk8350.h>
>  #include <dt-bindings/input/input.h>
>  #include <dt-bindings/leds/common.h>
> +#include <dt-bindings/media/video-interfaces.h>
> +#include <dt-bindings/media/video-interface-devices.h>

[Severity: Low]
Is it possible this include breaks the device tree compilation? The
dt-bindings/media/video-interface-devices.h header does not seem to exist in
the tree, and the C preprocessor will fail to find it.

>  #include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
>  #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
>  #include <dt-bindings/sound/qcom,q6asm.h>
> @@ -547,6 +549,29 @@ vreg_bob: bob {
>  	};
>  };
>  
> +&camss {

[Severity: Low]
Does this node reference an undefined label? The camss label does not appear
to be defined in sm6350.dtsi, sm7225.dtsi, or any other included device tree
file, which would result in a fatal device tree compiler error.

> +	vdd-csiphy0-0p9-supply = <&vreg_l18a>;
> +	vdd-csiphy0-1p25-supply = <&vreg_l22a>;
> +	vdd-csiphy1-0p9-supply = <&vreg_l18a>;
> +	vdd-csiphy1-1p25-supply = <&vreg_l22a>;
> +	vdd-csiphy2-0p9-supply = <&vreg_l18a>;
> +	vdd-csiphy2-1p25-supply = <&vreg_l22a>;
> +	vdd-csiphy3-0p9-supply = <&vreg_l18a>;
> +	vdd-csiphy3-1p25-supply = <&vreg_l22a>;
> +
> +	status = "okay";
> +
> +	ports {
> +		port@3 {

[Severity: Low]
Should this unit-addressed node include a reg property? Device tree
specifications require nodes with a unit address like port@3 to have a
corresponding reg or ranges property. Omitting it causes a dtc warning
(unit_address_vs_reg) and fails schema validation.

> +			csiphy3_ep: endpoint {
> +				data-lanes = <0 1 2 3>;
> +				bus-type = <MEDIA_BUS_TYPE_CSI2_DPHY>;
> +				remote-endpoint = <&camera_imx576_ep>;
> +			};
> +		};
> +	};
> +};
> +
[ ... ]
> @@ -581,7 +606,34 @@ &cci1 {
>  };
>  
>  &cci1_i2c0 {
> -	/* Front cam (Sony IMX576) @ 0x10 */
> +	camera@10 {
> +		compatible = "sony,imx576";

[Severity: Low]
Is this compatible string missing from the device tree bindings? There is no
corresponding YAML schema for sony,imx576 in Documentation/devicetree/bindings,
which will cause dtbs_check validation to fail.

> +		reg = <0x10>;
> +
> +		vana-supply = <&vreg_l3p>;
> +		vif-supply = <&vreg_l6p>;
> +		vdig-supply = <&vreg_32m_cam_dvdd_1p05>;
> +
> +		clocks = <&camcc CAMCC_MCLK1_CLK>;
> +		assigned-clocks = <&camcc CAMCC_MCLK1_CLK>;
> +		assigned-clock-rates = <24000000>;
> +
> +		reset-gpios = <&tlmm 35 GPIO_ACTIVE_LOW>;
> +		pinctrl-0 = <&cam_mclk1_default>;
> +		pinctrl-names = "default";
> +
> +		orientation = <MEDIA_ORIENTATION_FRONT>;

[Severity: Low]
Will this macro correctly expand? MEDIA_ORIENTATION_FRONT relies on the
dt-bindings/media/video-interface-devices.h header, which as noted earlier
is missing from the kernel tree and will cause a build failure.

> +		rotation = <90>;
> +
> +		port {
> +			camera_imx576_ep: endpoint {
> +				data-lanes = <1 2 3 4>;
> +				bus-type = <MEDIA_BUS_TYPE_CSI2_DPHY>;
> +				link-frequencies = /bits/ 64 <1017000000>;
> +				remote-endpoint = <&csiphy3_ep>;
> +			};
> +		};
> +	};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261009085041.181160-1-himanshu.bhavani@siliconsignals.io?part=1