From: sashiko-bot@kernel.org
To: phucduc.bui@gmail.com
Cc: lee@kernel.org, linux-leds@vger.kernel.org
Subject: Re: [PATCH v2 2/2] leds: lm3532: Avoid duplicate error messages
Date: Fri, 09 Oct 2026 09:29:25 +0000 [thread overview]
Message-ID: <sashiko-outbox-165168@kernel.org> (raw)
In-Reply-To: <20261009091059.25729-2-phucduc.bui@gmail.com>
> From: bui duc phuc <phucduc.bui@gmail.com>
>
> Most error paths in lm3532_parse_node() already log errors. Add an
> error message for the devm_add_action() failure and remove the
> redundant error message from lm3532_probe() to avoid duplicate logs.
>
> Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261009091059.25729-1-phucduc.bui@gmail.com?part=2
next prev parent reply other threads:[~2026-10-09 9:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-09 9:10 [PATCH v2 1/2] leds: lm3532: Propagate enable GPIO errors phucduc.bui
2026-10-09 9:10 ` [PATCH v2 2/2] leds: lm3532: Avoid duplicate error messages phucduc.bui
2026-10-09 9:29 ` sashiko-bot [this message]
2026-10-09 9:21 ` [PATCH v2 1/2] leds: lm3532: Propagate enable GPIO errors sashiko-bot
2026-10-13 8:24 ` Lee Jones
2026-10-13 8:49 ` Bui Duc Phuc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-165168@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=phucduc.bui@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.