From: sashiko-bot@kernel.org
To: "Vinod Koul" <vkoul@kernel.org>
Cc: dmaengine@vger.kernel.org, Frank.Li@kernel.org, vkoul@kernel.org
Subject: Re: [PATCH] docs: dmaengine: clarify ordering rules around cookie completion
Date: Fri, 09 Oct 2026 09:40:04 +0000 [thread overview]
Message-ID: <sashiko-outbox-165180@kernel.org> (raw)
In-Reply-To: <20261009093745.539924-1-vkoul@kernel.org>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] docs: typo 'architcure' and grammatical errors in dmaengine provider documentation
--
commit 5e1e4fe7c0e4434abe23aff6f6d55d9b232ea575
Author: Vinod Koul <vkoul@kernel.org>
docs: dmaengine: clarify ordering rules around cookie completion
This commit adds documentation to clarify the ordering rules for DMA cookie
completion, ensuring buffers are flushed before drivers invoke the completion.
> diff --git a/Documentation/driver-api/dmaengine/provider.rst b/Documentation/driver-api/dmaengine/provider.rst
> index f4ed98f701c91..073ba6c0f29dc 100644
> --- a/Documentation/driver-api/dmaengine/provider.rst
> +++ b/Documentation/driver-api/dmaengine/provider.rst
> @@ -555,6 +555,11 @@ dma_cookie_t
> - Not really relevant any more since the introduction of ``virt-dma``
> that abstracts it away.
>
> +- dmaengine drivers need to ensure buffers are flushed before invoking
> + vchan_cookie_complete() or dma_cookie_complete(). This would imply a call
> + to unmapping buffers or any such architcure calls to ensure caller seeing
> + buffers are flushed is done before invoking these calls.
[Severity: Low]
This isn't a bug, but there is a typo here ('architcure' instead of
'architecture'), and the phrasing "to ensure caller seeing buffers are
flushed is done before invoking these calls" is grammatically awkward.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261009093745.539924-1-vkoul@kernel.org?part=1
next prev parent reply other threads:[~2026-10-09 9:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-09 9:37 [PATCH] docs: dmaengine: clarify ordering rules around cookie completion Vinod Koul
2026-10-09 9:40 ` sashiko-bot [this message]
2026-10-09 13:40 ` Wolfram Sang
2026-10-09 16:15 ` Dave Jiang
2026-10-09 19:05 ` Frank Li
2026-10-11 20:31 ` Vinod Koul
2026-10-11 20:38 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-165180@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.