Re: [PATCH 3/4] arm64: ambarella: add ARCH_AMBARELLA and CV75 EVK DT

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] build: missing dt-bindings header ambarella,cv75-rct.h causes device tree build failure
--

commit a2925973f53816ca6808a0857931c68399b1d569
Author: Long Zhao <longzhao@ambarella.com>

arm64: ambarella: add ARCH_AMBARELLA and CV75 EVK DT

This commit enables the ARCH_AMBARELLA configuration and adds a minimal
CV75 SoC and EVK device tree for console bring-up.

> diff --git a/arch/arm64/boot/dts/ambarella/cv75.dtsi b/arch/arm64/boot/dts/ambarella/cv75.dtsi
> new file mode 100644
> index 0000000000000..c36b6af48237a
> --- /dev/null
> +++ b/arch/arm64/boot/dts/ambarella/cv75.dtsi
> @@ -0,0 +1,177 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> +/*
> + * Ambarella CV75 SoC
> + *
> + * Boot peripheral: UART0 console.
> + * Clocks: a single ambarella,cv75-rct provider.
> + */
> +
> +#include <dt-bindings/clock/ambarella,cv75-rct.h>

[Severity: Low]
Does this patch rely on a missing header file? The included header
dt-bindings/clock/ambarella,cv75-rct.h does not appear to be present in the
current tree or in this patch.

If a build is attempted with CONFIG_ARCH_AMBARELLA enabled, will it fail
with a fatal C preprocessor error since it cannot find this file to
evaluate CV75_GCLK_UART0 and CV75_GCLK_APB?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261009-cv75-soc-v1-0-808330e93ff1@ambarella.com?part=3