Re: [PATCH] evm: check return values of crypto_shash functions

[sashiko-bot@kernel.org]

> From: Daniel Hodges <git@danielhodges.dev>
> 
> The crypto_shash_update() and crypto_shash_final() functions can fail
> and return error codes, but their return values were not being checked
> in several places in security/integrity/evm/evm_crypto.c:
> 
> - hmac_add_misc() ignored returns from crypto_shash_update() and
>   crypto_shash_final()
> - evm_calc_hmac_or_hash() ignored returns from crypto_shash_update()
> - evm_init_hmac() ignored returns from crypto_shash_update()
> 
> If these hash operations fail silently, the resulting HMAC could be
> invalid or incomplete, which could weaken the integrity verification
> security that EVM provides.
> 
> [ ... ]
> [roberto.sassu@huawei.com: call hmac_add_misc() in evm_calc_hmac_or_hash()
>  only if no previous error, to avoid overwriting -ENODATA, and jump to out
>  only if hmac_add_misc() fails]
> Signed-off-by: Mimi Zohar <zohar@linux.ibm.com>
> Signed-off-by: Roberto Sassu <roberto.sassu@huawei.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261009111212.1516243-1-roberto.sassu@huaweicloud.com?part=1