Re: [PATCH 1/3] dt-bindings: power: Convert Ux500 PM domains to schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: node name pm_domains0 violates generic power-domain.yaml pattern
--

commit e036f4f6150d2ad689c2435137c3f93e75ad275c
Author: Linus Walleij <linusw@kernel.org>
Subject: dt-bindings: power: Convert Ux500 PM domains to schema

Convert the legacy Ux500 power domain text binding to YAML. Move it under
bindings/power. Reference the generic power-domain schema.

> diff --git a/Documentation/devicetree/bindings/power/stericsson,ux500-pm-domains.yaml b/Documentation/devicetree/bindings/power/stericsson,ux500-pm-domains.yaml
> new file mode 100644
> index 0000000000000..bf83ce3326746
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/stericsson,ux500-pm-domains.yaml
> @@ -0,0 +1,41 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---

[ ... ]

> +allOf:
> +  - $ref: power-domain.yaml#
> +

[Severity: Low]
Does referencing the generic power-domain.yaml cause dtbs_check to fail for
existing device trees?

By referencing the generic power-domain schema, this binding strictly enforces
its node name pattern:
^(power-controller|power-domain|performance-domain)([@-].*)?$

However, the existing device tree node in arch/arm/boot/dts/st/ste-dbx5x0.dtsi
is named pm_domains0:

		pm_domains: pm_domains0 {
			compatible = "stericsson,ux500-pm-domains";
			#power-domain-cells = <1>;
		};

While the example below was updated to power-controller to pass local
dt_binding_check, the corresponding .dtsi file was omitted from this patch.
Should the .dtsi file be updated in this series to prevent a lingering
dtbs_check validation regression?

[ ... ]

> +examples:
> +  - |
> +    #include <dt-bindings/arm/ux500_pm_domains.h>
> +
> +    pm_domains: power-controller {
> +        compatible = "stericsson,ux500-pm-domains";
> +        #power-domain-cells = <1>;
> +    };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261009-ux500-power-domains-v7-3-rc1-redux-v1-0-5eb1b90bc35e@kernel.org?part=1