Re: [PATCH v14 04/15] drm/panfrost: Skip NULL checks for clock enable/disabling

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] drm/panfrost: missing error check for dev_pm_opp_set_opp in resume path
--

commit 551cc4e2301b0de24ff4541df0b0044dcc43f6d9
Author: Adrián Larumbe <adrian.larumbe@collabora.com>
Subject: drm/panfrost: Skip NULL checks for clock enable/disabling

This commit removes NULL checks before calling clk_enable() and
clk_disable() in the panfrost device suspend and resume paths. The clk_*
API can handle NULL clock objects safely.

> diff --git a/drivers/gpu/drm/panfrost/panfrost_device.c b/drivers/gpu/drm/panfrost/panfrost_device.c
> index 5bf528f41278d..b3a53504bd016 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_device.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_device.c
> @@ -510,11 +510,9 @@ static int panfrost_device_resume(struct device *dev)
>  		if (ret)
>  			goto err_clk;
>  

[Severity: Medium]
In panfrost_device_resume() just above this modified code,
dev_pm_opp_set_opp() is called without checking its return value:

	dev_pm_opp_set_opp(dev, opp);
	dev_pm_opp_put(opp);

Does this allow the resume sequence to proceed even if voltage
configuration fails?

If this configuration fails, the GPU may remain unpowered or improperly
powered. Proceeding to access GPU hardware in this state can lead to
imprecise external aborts and system lockups.

> -		if (pfdev->bus_clock) {
> -			ret = clk_enable(pfdev->bus_clock);
> -			if (ret)
> -				goto err_bus_clk;
> -		}
> +		ret = clk_enable(pfdev->bus_clock);
> +		if (ret)
> +			goto err_bus_clk;
>  	}
>

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261009-claude-fixes-v14-0-cb743b3b973b@collabora.com?part=4