Re: [PATCH v2 6/7] HID: asus: add prod-id, quirk for Zenbook Duo keyboard

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] hid: hid-asus hijacks Zenbook Duo touchpad over Bluetooth
--

commit 5e5f2becf13b4e6d6ecb2a2d14e80b4b0f934932
Author: Luke Jones <luke@ljones.dev>

HID: asus: add prod-id, quirk for Zenbook Duo keyboard

This commit adds USB and Bluetooth device IDs for the 2024/2025/2026 ASUS
Zenbook Duo detachable keyboards. It sets up initialization quirks and binds
the USB IDs strictly to HID_GROUP_GENERIC so the touchpad interface can be
handled by hid-multitouch.

> diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c
> --- a/drivers/hid/hid-asus.c
> +++ b/drivers/hid/hid-asus.c

[ ... ]

> @@ -1834,6 +1834,29 @@ static const struct hid_device_id asus_devices[] = {
>  	  QUIRK_USE_KBD_BACKLIGHT | QUIRK_ROG_NKEY_KEYBOARD },
>  	{ HID_DEVICE(BUS_USB, HID_GROUP_GENERIC,
>  		USB_VENDOR_ID_ASUSTEK, USB_DEVICE_ID_ASUSTEK_T101HA_KEYBOARD) },
> +	/*
> +	 * Zenbook Duo detachable keyboards. Bind the USB IDs to the
> +	 * HID_GROUP_GENERIC group only, like the ROG Z13 Folio, so that
> +	 * hid-multitouch keeps handling the touchpad interfaces.
> +	 */
> +	{ HID_DEVICE(BUS_USB, HID_GROUP_GENERIC, USB_VENDOR_ID_ASUSTEK,
> +	    USB_DEVICE_ID_ASUSTEK_ZENBOOK_DUO_UX8406MA_KEYBOARD),
> +	  QUIRK_USE_KBD_BACKLIGHT | QUIRK_ZENBOOK_DUO_KEYBOARD },
> +	{ HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_ASUSTEK,
> +	    BT_DEVICE_ID_ASUSTEK_ZENBOOK_DUO_UX8406MA_KEYBOARD),
> +	  QUIRK_USE_KBD_BACKLIGHT | QUIRK_ZENBOOK_DUO_KEYBOARD },

[Severity: High]
The commit message notes the intent to restrict USB IDs to HID_GROUP_GENERIC,
so that hid-multitouch keeps handling the touchpad. Will using
HID_BLUETOOTH_DEVICE for the Bluetooth IDs cause hid-asus to unintentionally
hijack the touchpad over Bluetooth?

HID_BLUETOOTH_DEVICE sets .group to HID_GROUP_ANY (0). Because
hid_match_one_id() treats HID_GROUP_ANY as a wildcard, hid-asus will match
and bind to all HID device nodes that share this Vendor and Product ID,
including the HID_GROUP_MULTITOUCH_WIN_8 node.

Should these Bluetooth IDs (for UX8406MA, UX8406CA, and UX8407AA) explicitly
use HID_DEVICE with HID_GROUP_GENERIC to match the USB ID behavior and
prevent the multitouch driver from losing PTP capabilities?

> +	{ HID_DEVICE(BUS_USB, HID_GROUP_GENERIC, USB_VENDOR_ID_ASUSTEK,
> +	    USB_DEVICE_ID_ASUSTEK_ZENBOOK_DUO_UX8406CA_KEYBOARD),
> +	  QUIRK_USE_KBD_BACKLIGHT | QUIRK_ZENBOOK_DUO_KEYBOARD },
> +	{ HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_ASUSTEK,
> +	    BT_DEVICE_ID_ASUSTEK_ZENBOOK_DUO_UX8406CA_KEYBOARD),
> +	  QUIRK_USE_KBD_BACKLIGHT | QUIRK_ZENBOOK_DUO_KEYBOARD },
> +	{ HID_DEVICE(BUS_USB, HID_GROUP_GENERIC, USB_VENDOR_ID_ASUSTEK,
> +	    USB_DEVICE_ID_ASUSTEK_ZENBOOK_DUO_UX8407AA_KEYBOARD),
> +	  QUIRK_USE_KBD_BACKLIGHT | QUIRK_ZENBOOK_DUO_KEYBOARD },
> +	{ HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_ASUSTEK,
> +	    BT_DEVICE_ID_ASUSTEK_ZENBOOK_DUO_UX8407AA_KEYBOARD),
> +	  QUIRK_USE_KBD_BACKLIGHT | QUIRK_ZENBOOK_DUO_KEYBOARD },
>  	{ }
>  };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261009153459.124752-1-p.pisati@gmail.com?part=6