From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AECCCCA601E for ; Fri, 9 Oct 2026 18:39:02 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 05E2410EAFA; Fri, 9 Oct 2026 18:39:02 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="CNiqfU0+"; dkim-atps=neutral Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by gabe.freedesktop.org (Postfix) with ESMTPS id EB6CD10EAFA for ; Fri, 9 Oct 2026 18:39:00 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 6E29B60267; Fri, 9 Oct 2026 18:39:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 45F531F000FF; Fri, 9 Oct 2026 18:38:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791571140; bh=XvSkH/vkDzBCc6Yy8pr97AcLVmOtcCshhf7Oxisq2Qg=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=CNiqfU0+XQz1FN52FxePWCSUPhMXxOlq+mzLafif7EQRjvexDQ2BO2lwDBBBqpkFp LdvOBmzuXtknKNZpNfsKYHu/MfJ8ehCM2uQ1XxHWT2vpHHJIV6IPLoNFaUc7FvH3nw WpuYKKm91z+54yCqanQm3bF01ROuuDAzJk8/lfkUHLHCsPtZP4eSIxuWAxGlqdiyuM WNb9nJjYZGNI8Z9J8iNeqo6WInTKtlRgzIgHNncGtRSOe45AJr/Y6LJPuN4HP7wd8y 3qtse4BIAR9YyOPYQbbYvye4G9LsnxnyzaDdLqiFCoiDyz1DBYYFS/tmuHppts+xk8 ncqXHBNVNhYuQ== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v5 26/38] mm: remove hugetlb_inline.h To: =?utf-8?b?TG9yZW56byBTdG9ha2VzIChBUk0p?= Cc: "Heiko Carstens" , "Christian Borntraeger" , linux-s390@vger.kernel.org, kvmarm@lists.linux.dev, "Oliver Upton" , linux-rdma@vger.kernel.org, linux-usb@vger.kernel.org, bpf@vger.kernel.org, selinux@vger.kernel.org, dri-devel@lists.freedesktop.org, kvm@vger.kernel.org, linux-perf-users@vger.kernel.org, "Marc Zyngier" , "Vasily Gorbik" , "Alexander Gordeev" , linux-scsi@vger.kernel.org, linux-trace-kernel@vger.kernel.org In-Reply-To: <20261009-b4-mmap-prepare-vma-flag-sanify-v5-26-923b70125b1e@kernel.org> References: <20261009-b4-mmap-prepare-vma-flag-sanify-v5-0-923b70125b1e@kernel.org> <20261009-b4-mmap-prepare-vma-flag-sanify-v5-26-923b70125b1e@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 09 Oct 2026 18:38:58 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" > This header really makes little sense - every place it is included mm.h is > also included, and the header itself includes mm.h, so it does nothing to > reduce header size. >=20 > It also oddly does an #ifdef around checking VMA_HUGETLB_BIT, however > VMA_HUGETLB_BIT is unconditionally available, and will never be set if > hugetlb is not enabled. >=20 > Simply remove the header, eliminate the odd ifdeffery and place the > predicates in mm.h. >=20 > The naming of these predicates is odd, but to keep changes separate, we > will address this in a separate patch. >=20 > The file was never put into MAINTAINERS so there's no change required > there. >=20 > No functional change intended. >=20 > Reviewed-by: Zi Yan > Acked-by: David Hildenbrand (Arm) > Signed-off-by: Lorenzo Stoakes (ARM) Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261009-b4-mmap-pr= epare-vma-flag-sanify-v5-0-923b70125b1e@kernel.org?part=3D26